-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gl_engine: rewrite the blending shader #3081
base: main
Are you sure you want to change the base?
Conversation
2c438bf
to
a7e2b61
Compare
@RuiwenTang Please check this: |
@RuiwenTang I'd like to recommend separating the incorrect equation (ColorBurn, ColorEdge) from the destination alpha issue. We can apply the equation correction commit first. |
@hermet |
|
e09b853
to
d07b491
Compare
Completely rewrite the GL backend shader to support advance blending and correct the blending behavior. Now the GL backend has the same blending result as SKIA and CanvasRenderingContext2D in browers did. The formula is referenced from https://www.w3.org/TR/compositing-1/#porterduffcompositingoperators
d07b491
to
4a7ce3a
Compare
Completely rewrite the GL backend shader to support advance blending and correct the blending behavior.
Now the GL backend has the same blending result as SKIA and CanvasRenderingContext2D in browers did.
The formula is referenced from https://www.w3.org/TR/compositing-1/#porterduffcompositingoperators
Note this change make the
Blending
example rendered different with other backend, but the result is consistent with SKIA, which I believe is correct.The current rendering result can reference this issue #3072
It also fix the blending issue in Lottie animation: #2799