-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement one finger panning in pen mode #5026
base: main
Are you sure you want to change the base?
Conversation
@gekiclaws is attempting to deploy a commit to the tldraw Team on Vercel. A member of the Team first needs to authorize it. |
2 out of 2 authors have signed the CLA. Thanks! |
I have read and agree to the Contributor License Agreement. |
Thanks for the PR @gekiclaws! I like the basic idea a lot. One of the reasons we have pen mode at all is that palm rejection is very bad in browsers such as iPad Safari. My worry here is that allowing for touch navigation would cause accidental palm taps to move the camera, in the same way that they used to make dots! Have you had a chance to try this at all on a tablet, and did you notice any accidental movement from palms? Maybe we could use two-finger navigation instead? |
Hi Steve, I've had a chance to test this on my S24 Ultra using the S Pen to verify my feature edit works in my local deployment. I didn’t initially consider the issue of accidental palm taps, but I’ve now tested two cases in pen mode on my phone:
The existing two-finger navigation is great when drawing with a finger, but when using a stylus, one-finger panning feels much more natural. Two-finger navigation is also still supported. Let me know what you think! |
Restores middle mouse button and spacebar panning functionality
5d7969d
to
905f948
Compare
Restores middle mouse button and spacebar panning functionality
Tests for single-finger panning in pen mode
I have read and agree to the Contributor License Agreement. |
Describe what your pull request does.
This PR introduces changes to improve the behavior of pen mode and touch interactions:
When pen mode is active:
Preserved Existing Functionality:
Addresses #4816.
Change type
bugfix
improvement
feature
api
other
Test plan
Added additional tests to each to ensure that when pen mode is activated, it does not affect their functionality.
Release notes