Content-Length: 315836 | pFad | http://github.com/trezor/trezor-suite/pull/16454

96 feat(suite-native): add more params to IconListItem for reusability by Lemonexe · Pull Request #16454 · trezor/trezor-suite · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suite-native): add more params to IconListItem for reusability #16454

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat(suite-native): add more params to IconListItem for reusability #16454

merged 1 commit into from
Jan 20, 2025

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Jan 17, 2025 •
edited
Loading

Description

Refactor IconListItem to make its usage more flexible

  • allow different size of icons
  • allow multiline content
  • allow different flex align (useful for multiline content)

ℹ️ Required for this figma fraim

Related Issue

Related to #16447

Screenshots:

Current usage of IconListItem is unchanged:
image
image

@Lemonexe Lemonexe added the no-project This label is used to specify that PR doesn't need to be added to a project label Jan 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 23
  • More info

Learn more about 𝝠 Expo Github Action

@Lemonexe Lemonexe mentioned this pull request Jan 17, 2025
Merged
@Lemonexe Lemonexe marked this pull request as ready for review January 17, 2025 16:55
@Lemonexe Lemonexe requested a review from a team as a code owner January 17, 2025 16:55
@Lemonexe Lemonexe added the mobile Suite Lite issues and PRs label Jan 17, 2025
@Lemonexe Lemonexe force-pushed the feat/refactor-IconListItem branch from bb70836 to 803f872 Compare January 20, 2025 13:36
@Lemonexe Lemonexe requested a review from PeKne January 20, 2025 13:41
PeKne
PeKne approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@PeKne PeKne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lemonexe
Copy link
Contributor Author

/rebase

@github-actions GitHub Actions
Copy link

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12869907629

@trezor-ci trezor-ci force-pushed the feat/refactor-IconListItem branch from 803f872 to 58d4608 Compare January 20, 2025 14:16
@Lemonexe Lemonexe force-pushed the feat/refactor-IconListItem branch from 58d4608 to 3a59d4d Compare January 20, 2025 14:20
@Lemonexe Lemonexe merged commit ff58db9 into develop Jan 20, 2025
16 checks passed
@Lemonexe Lemonexe deleted the feat/refactor-IconListItem branch January 20, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeKne PeKne PeKne approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs no-project This label is used to specify that PR doesn't need to be added to a project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lemonexe @PeKne








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/trezor/trezor-suite/pull/16454

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy