Content-Length: 371122 | pFad | http://github.com/typescript-eslint/typescript-eslint/pull/11315

B4 docs: remove legacy note about __dirname by cseas · Pull Request #11315 · typescript-eslint/typescript-eslint · GitHub
Skip to content

docs: remove legacy note about __dirname #11315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2025
Merged

docs: remove legacy note about __dirname #11315

merged 3 commits into from
Jun 24, 2025
+0 −5

Conversation

cseas
Copy link
Contributor

@cseas cseas commented Jun 18, 2025 •
edited
Loading

PR Checklist

Overview

Removed the note about __dirname as suggested in #11314 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cseas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 15a8289
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/685b1ed0384e220008b35893
😎 Deploy Preview https://deploy-preview-11315--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 90 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 15a8289.

Command Status Duration Result
nx run-many -t typecheck ✅ Succeeded 1m 58s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 12s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded <1s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run-many -t lint ✅ Succeeded 10s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded <1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-24 22:00:59 UTC

JoshuaKGoldberg
JoshuaKGoldberg requested changes Jun 23, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this one! 😄

I agree with @kirkwaiblinger's #11314 (comment) - it's a good point that a lot of users aren't familiar with CJS vs. ESM. Let's just remove the one __dirname note for now, and leave the two CJS/ESM notes.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 23, 2025
@cseas
Copy link
Contributor Author

cseas commented Jun 24, 2025 •
edited
Loading

@JoshuaKGoldberg ✅ Done! Added the CJS/ESM notes back.

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (d19c9f3) to head (15a8289).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11315   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         501      501           
  Lines       50919    50919           
  Branches     8386     8386           
=======================================
  Hits        46256    46256           
  Misses       4648     4648           
  Partials       15       15
Flag Coverage Δ
unittest 90.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cseas cseas changed the title docs: remove legacy notes about CJS extensions and __dirname docs: remove legacy note about __dirname Jun 24, 2025
@cseas cseas requested a review from JoshuaKGoldberg June 24, 2025 11:01
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 24, 2025
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🙌

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 24, 2025
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) June 24, 2025 21:55
@kirkwaiblinger kirkwaiblinger merged commit 3ecb96f into typescript-eslint:main Jun 24, 2025
60 of 61 checks passed
@cseas cseas deleted the docs-legacy-cjs branch June 25, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cseas @JoshuaKGoldberg @kirkwaiblinger








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/typescript-eslint/typescript-eslint/pull/11315

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy