fix(typescript-estree): ensure the token type of the property name is Identifier #11329
Conversation
|
Thanks for the PR, @ntdiary! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit fa670da.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11329 +/- ##
==========================================
+ Coverage 90.84% 90.85% +0.01%
==========================================
Files 501 501
Lines 50919 50901 -18
Branches 8387 8381 -6
==========================================
- Hits 46256 46246 -10
+ Misses 4648 4641 -7
+ Partials 15 14 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR Checklist
ifin the 262IdentifierNameproduction should be Identifier instead of Keyword #11037Overview
I've gone with option 1 in the comments for now, if any regressions come up later, we can discuss them or try the other option if needed. :)
💖