Fix toast notification can not be closed #19510
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
requested changes
Jun 9, 2025
There was a problem hiding this comment.
I'll have to leave this for a FE expert to review to see if the solution is a good one @NguyenThuyLan, but before they get to it, I'd suggest looking to clean up the linting errors.
There are these thrown, all around using const or let over var - being more explicit about the variable declaration and aligning with the rest of the code base:
/home/runner/work/Umbraco-CMS/Umbraco-CMS/src/Umbraco.Web.UI.Client/src/packages/core/components/backoffice-modal-container/backoffice-modal-container.element.ts
Error: 89:3 error Unexpected var, use let or const instead no-var
Error: 90:3 error Unexpected var, use let or const instead no-var
Error: 91:3 error Unexpected var, use let or const instead no-var
Error: 128:3 error Unexpected var, use let or const instead no-var
Error: 133:3 error Unexpected var, use let or const instead no-var
I'd also "nit-pick" being consistent with spacing. E.g. where you have if (!modalSidebar) { it's correct, but if(!dialog){ is missing expected spacing. Of course this doesn't change anything functionally, but it's cleaner to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes
Description
This PR fixes for #16486
Reason:
The showModal() method of the HTMLDialogElement interface displays the dialog as a modal, over the top of any other dialogs that might be present. That's why toast-notification (popover ) stays non-interactive despite appearing above the modal.
Solution:
When the dialog is opened, move the
umb-backoffice-notification-containerinside the dialog so that the notification can be interacted with, and when the dialog is closed, move the notification back out to the DOM.