Fix issues with removal of user logins on change to external login provider configuration (16) #19512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal login providers. Ensure to avoid removing logins for members.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the removal of external logins associated with user accounts when their external login provider configuration changes. It updates the deletion logic in the repository by refining the filtering criteria and consolidating duplicate deletion logic into a dedicated helper method.
- Refined deletion criteria in DeleteUserLoginsForRemovedProviders to exclude member logins.
- Consolidated token and login deletions into a common helper method (DeleteExternalLogins).
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ExternalLoginRepository.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ExternalLoginRepository.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent of #19511 resolving #19499 for Umbraco 16.
See linked PR for details.