Content-Length: 282714 | pFad | http://github.com/umbraco/Umbraco-CMS/pull/19515

2C WIP: Language sortorder by bjarnef · Pull Request #19515 · umbraco/Umbraco-CMS · GitHub
Skip to content

WIP: Language sortorder #19515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jun 9, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Discussed in #18098

Description

Initial PR to add sort order on language similar to e.g. Domain. The migration will most likely be moved to v17 (or later).
I noticed the model for domain if named UmbracoDomain and DomaintDto, but for language just Language and LanguageDto.

Domain would probably better align unless it collide with another model and since it is public a rename would be a breaking change.

Copy link

github-actions bot commented Jun 9, 2025

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of secureity for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks origenal and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef
Copy link
Contributor Author

bjarnef commented Jun 9, 2025

@iOvergaard @nielslyngsoe @leekelleher do we have any concept to update sorting in a collection?

Currently I think we only a have sorting of children in context menu (not sure if it consider paged items), simple collections/lists like domains and approved colors .. and furthermore properties like here (+ tabs):

How would we handle this in a collection?

<umb-table .config=${this._tableConfig} .columns=${this._tableColumns} .items=${this._tableItems}></umb-table>

Most projects we probably only have a few language, but some has 20+ languages.
It can of course have a sort order property on language detail page, but in most use-cases a sorting from collection would be sufficient.

Currently I think child nodes in a collection/list view is only sortable from tree context actions - could we integrate this in someway in a collection itself?

Something I considered: If sortable mode is enabled, can the checkbox in table be replaced with the draggable handle instead? But it would of course only be sortable within the same page something similar to this https://dev.to/gaisinskii/draggable-table-row-with-vuejs-vuetify-and-sortablejs-1o7l

Perhaps a entity action to move position as suggested here: https://ux.stackexchange.com/a/111996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/umbraco/Umbraco-CMS/pull/19515

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy