Better changes detection in release reporting #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
commented
Feb 15, 2025
Comment on lines
+76
to
+56
| if let comparisonRange = self.findComparisonRange() { | ||
| try await self.getCommitsInRelease( | ||
| comparisonRange: comparisonRange | ||
| ) |
There was a problem hiding this comment.
get the comparison range from **Full Changelog**: https://github.com/DiscordBM/DiscordBM/compare/v1.12.2...v1.13.0 texts when possible.
MahdiBM
commented
Feb 16, 2025
| ) | ||
| ) | ||
| } | ||
|
|
||
| func findUseableImageLink() async -> String? { |
There was a problem hiding this comment.
Sometimes Discord fails to show an image for a release. I think this should fix it.
MahdiBM
force-pushed
the
mmbm-better-release-commit-detection
branch
2 times, most recently
from
56e0fac to
5968d87
Compare
MahdiBM
force-pushed
the
mmbm-better-release-commit-detection
branch
from
5968d87 to
72463aa
Compare
MahdiBM
force-pushed
the
mmbm-better-release-commit-detection
branch
from
79bf677 to
cc3a0b4
Compare
…tion' into mmbm-better-release-commit-detection
gwynne
reviewed
Feb 18, 2025
| @@ -135,6 +135,7 @@ struct ReleaseMaker { | |||
| if let (_, version) = SemanticVersion.fromGitHubTag(release.tagName) { | |||
| return (release, version) | |||
| } | |||
| logger.warning("Could not parse tag", metadata: ["tag": .string(release.tagName)]) | |||
There was a problem hiding this comment.
I believe the preferred form for this is:
Suggested change
| logger.warning("Could not parse tag", metadata: ["tag": .string(release.tagName)]) | |
| logger.warning("Could not parse tag", metadata: ["tag": "\(release.tagName)"]) |
There was a problem hiding this comment.
I don't believe that tbh, I always use explicit .string when the thing is an string 😅
Shouldn't make much of a difference in the end but yeah that's what I've been going with
gwynne
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.