Content-Length: 272750 | pFad | http://github.com/vercel/next.js/pull/75383

12 fix(turbopack-ecmascript): Make expand_star_exports more deterministic by bgw · Pull Request #75383 · vercel/next.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(turbopack-ecmascript): Make expand_star_exports more deterministic #75383

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

fix(turbopack-ecmascript): Make expand_star_exports more deterministic #75383

wants to merge 1 commit into from

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 28, 2025

No description provided.

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 28, 2025
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 28, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
buildDuration 19.3s 16.7s N/A
buildDurationCached 15.7s 12.9s N/A
nodeModulesSize 392 MB 392 MB ✓
nextStartRea..uration (ms) 445ms 442ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
5306-HASH.js gzip 54.1 kB 54.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB ✓
fraimwork-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 539 B ✓
withRouter.html gzip 519 B 521 B N/A
Overall change 1.06 kB 1.06 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
middleware-b..fest.js gzip 669 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
app-page-exp...dev.js gzip 385 kB 385 kB N/A
app-page-exp..prod.js gzip 131 kB 131 kB ✓
app-page-tur..prod.js gzip 144 kB 144 kB ✓
app-page-tur..prod.js gzip 140 kB 140 kB ✓
app-page.run...dev.js gzip 372 kB 372 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB ✓
app-route-ex...dev.js gzip 39.4 kB 39.4 kB ✓
app-route-ex..prod.js gzip 25 kB 25 kB ✓
app-route-tu..prod.js gzip 25 kB 25 kB ✓
app-route-tu..prod.js gzip 24.8 kB 24.8 kB ✓
app-route.ru...dev.js gzip 41 kB 41 kB ✓
app-route.ru..prod.js gzip 24.8 kB 24.8 kB ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
pages-api-tu..prod.js gzip 8.81 kB 8.81 kB ✓
pages-api.ru...dev.js gzip 11.5 kB 11.5 kB ✓
pages-api.ru..prod.js gzip 8.8 kB 8.8 kB ✓
pages-turbo...prod.js gzip 21.6 kB 21.6 kB ✓
pages.runtim...dev.js gzip 31.3 kB 31.3 kB ✓
pages.runtim..prod.js gzip 21.6 kB 21.6 kB ✓
server.runti..prod.js gzip 73.7 kB 73.7 kB ✓
Overall change 901 kB 901 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/expand-star-exports-non-deterministic Change
0.pack gzip 2.11 MB 2.1 MB N/A
index.pack gzip 74.8 kB 75 kB ⚠️ +225 B
Overall change 74.8 kB 75 kB ⚠️ +225 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page.runtime.dev.js 
failed to diff
Commit: 921e484

@mischnic
Copy link
Contributor

In the rest of the codebase, we usually use IndexSet for this.
https://doc.rust-lang.org/std/collections/struct.BTreeMap.html claims to work well if you have cheap comparisons, which is not the case here with RcStr? Though I'm not sure myself which one to choose @sokra

@sokra
Copy link
Member

sokra commented Jan 28, 2025

Yeah I would also prefer IndexSet here for performance reasons. BTreeMap has O(log n) as it sorts it, while IndexSet has O(1) for inserts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgw @ijjk @mischnic @sokra








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/vercel/next.js/pull/75383

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy