Content-Length: 391882 | pFad | http://github.com/vueuse/vueuse/pull/4857

F8 fix(useVirtualList): resolve invalid watch source by cszhjh · Pull Request #4857 · vueuse/vueuse · GitHub
Skip to content

fix(useVirtualList): resolve invalid watch source #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 11, 2025
Merged

fix(useVirtualList): resolve invalid watch source #4857

merged 7 commits into from
Jul 11, 2025

Conversation

cszhjh
Copy link
Contributor

@cszhjh cszhjh commented Jul 6, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Ensure that the list being listened to is always reactive data.

Additional context

fixes #4854

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 6, 2025
OrbisK
OrbisK reviewed Jul 8, 2025
View reviewed changes
OrbisK
OrbisK requested changes Jul 8, 2025
View reviewed changes
@cszhjh
Copy link
Contributor Author

cszhjh commented Jul 8, 2025

@OrbisK Thank you for your review, I have updated the code.

OrbisK
OrbisK previously approved these changes Jul 8, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2025
ilyaliao
ilyaliao previously approved these changes Jul 9, 2025
View reviewed changes
@OrbisK OrbisK requested a review from 43081j July 9, 2025 10:51
@43081j
Copy link
Collaborator

43081j commented Jul 9, 2025 •
edited
Loading

can you add a test too?

just set the list as a fixed array or something instead of a ref, in the test

if you also catch up from main, the docs build will succeed (although happy to merge regardless of that in this case)

@cszhjh
Copy link
Contributor Author

cszhjh commented Jul 9, 2025

can you add a test too?

just set the list as a fixed array or something instead of a ref, in the test

if you also catch up from main, the docs build will succeed (although happy to merge regardless of that in this case)

Okey, Tonight I will increase the test cases.

@cszhjh cszhjh dismissed stale reviews from ilyaliao and OrbisK via 313d763 July 9, 2025 13:02
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 9, 2025
@cszhjh cszhjh force-pushed the fix-useVirtualList branch from 313d763 to ae0720c Compare July 9, 2025 13:04
@cszhjh
Copy link
Contributor Author

cszhjh commented Jul 9, 2025

can you add a test too?

just set the list as a fixed array or something instead of a ref, in the test

if you also catch up from main, the docs build will succeed (although happy to merge regardless of that in this case)

Thank you for your review, I have added test case.

43081j
43081j reviewed Jul 9, 2025
View reviewed changes
@cszhjh cszhjh force-pushed the fix-useVirtualList branch from f246884 to 1d8a5db Compare July 9, 2025 14:59
@cszhjh cszhjh force-pushed the fix-useVirtualList branch from 1d8a5db to 8af4815 Compare July 9, 2025 15:00
43081j
43081j reviewed Jul 9, 2025
View reviewed changes
@43081j 43081j added this pull request to the merge queue Jul 11, 2025
Merged via the queue into vueuse:main with commit d23812d Jul 11, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

@OrbisK OrbisK OrbisK left review comments

@ilyaliao ilyaliao ilyaliao approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG | useVirtualList | Invalid watch source with doc example
4 participants
@cszhjh @43081j @OrbisK @ilyaliao








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/vueuse/vueuse/pull/4857

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy