Cloning iterators #278
Closed
Cloning iterators #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarfonthey
force-pushed
the
iter_clone
branch
from
cf165a8 to
70b6c2f
Compare
clarfonthey
force-pushed
the
iter_clone
branch
from
70b6c2f to
6d4f50b
Compare
|
Closing because this hasn't been merged in a while. Would love to see this change and you're free to apply it anyway, but, I want to keep my list of open PRs clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to clone iterators even when the keys and values of a map are not cloneable, since they aren't being cloned.
It also makes a small change to
IterSetto default the map argument, likeIterdoes.