forked from apache/iceberg
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Flink: Prevent setting endTag/endSnapshotId for streaming source (apa…
- Loading branch information
Showing
8 changed files
with
180 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestScanContext.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.iceberg.flink.source; | ||
|
|
||
| import org.assertj.core.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class TestScanContext { | ||
| @Test | ||
| void testIncrementalFromSnapshotId() { | ||
| ScanContext context = | ||
| ScanContext.builder() | ||
| .streaming(true) | ||
| .startingStrategy(StreamingStartingStrategy.INCREMENTAL_FROM_SNAPSHOT_ID) | ||
| .build(); | ||
| assertException( | ||
| context, "Invalid starting snapshot id for SPECIFIC_START_SNAPSHOT_ID strategy: null"); | ||
|
|
||
| context = | ||
| ScanContext.builder() | ||
| .streaming(true) | ||
| .startingStrategy(StreamingStartingStrategy.INCREMENTAL_FROM_SNAPSHOT_ID) | ||
| .startSnapshotId(1L) | ||
| .startSnapshotTimestamp(1L) | ||
| .build(); | ||
| assertException( | ||
| context, | ||
| "Invalid starting snapshot timestamp for SPECIFIC_START_SNAPSHOT_ID strategy: not null"); | ||
| } | ||
|
|
||
| @Test | ||
| void testIncrementalFromSnapshotTimestamp() { | ||
| ScanContext context = | ||
| ScanContext.builder() | ||
| .streaming(true) | ||
| .startingStrategy(StreamingStartingStrategy.INCREMENTAL_FROM_SNAPSHOT_TIMESTAMP) | ||
| .build(); | ||
| assertException( | ||
| context, | ||
| "Invalid starting snapshot timestamp for SPECIFIC_START_SNAPSHOT_TIMESTAMP strategy: null"); | ||
|
|
||
| context = | ||
| ScanContext.builder() | ||
| .streaming(true) | ||
| .startingStrategy(StreamingStartingStrategy.INCREMENTAL_FROM_SNAPSHOT_TIMESTAMP) | ||
| .startSnapshotId(1L) | ||
| .startSnapshotTimestamp(1L) | ||
| .build(); | ||
| assertException( | ||
| context, "Invalid starting snapshot id for SPECIFIC_START_SNAPSHOT_ID strategy: not null"); | ||
| } | ||
|
|
||
| @Test | ||
| void testStreaming() { | ||
| ScanContext context = ScanContext.builder().streaming(true).useTag("tag").build(); | ||
| assertException(context, "Cannot scan table using ref tag configured for streaming reader"); | ||
|
|
||
| context = ScanContext.builder().streaming(true).useSnapshotId(1L).build(); | ||
| assertException(context, "Cannot set snapshot-id option for streaming reader"); | ||
|
|
||
| context = ScanContext.builder().streaming(true).asOfTimestamp(1L).build(); | ||
| assertException(context, "Cannot set as-of-timestamp option for streaming reader"); | ||
|
|
||
| context = ScanContext.builder().streaming(true).endSnapshotId(1L).build(); | ||
| assertException(context, "Cannot set end-snapshot-id option for streaming reader"); | ||
|
|
||
| context = ScanContext.builder().streaming(true).endTag("tag").build(); | ||
| assertException(context, "Cannot set end-tag option for streaming reader"); | ||
| } | ||
|
|
||
| @Test | ||
| void testStartConflict() { | ||
| ScanContext context = ScanContext.builder().startTag("tag").startSnapshotId(1L).build(); | ||
| assertException(context, "START_SNAPSHOT_ID and START_TAG cannot both be set."); | ||
| } | ||
|
|
||
| @Test | ||
| void testEndConflict() { | ||
| ScanContext context = ScanContext.builder().endTag("tag").endSnapshotId(1L).build(); | ||
| assertException(context, "END_SNAPSHOT_ID and END_TAG cannot both be set."); | ||
| } | ||
|
|
||
| @Test | ||
| void testMaxAllowedPlanningFailures() { | ||
| ScanContext context = ScanContext.builder().maxAllowedPlanningFailures(-2).build(); | ||
| assertException( | ||
| context, "Cannot set maxAllowedPlanningFailures to a negative number other than -1."); | ||
| } | ||
|
|
||
| private void assertException(ScanContext context, String message) { | ||
| Assertions.assertThatThrownBy(() -> context.validate()) | ||
| .hasMessage(message) | ||
| .isInstanceOf(IllegalArgumentException.class); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters