Content-Length: 191424 | pFad | http://phabricator.wikimedia.org/T113758

s ⚓ T113758 Convert DeleteAction.php/SpecialUndelete.php to use OOUI
Page MenuHomePhabricator
Create Task
Maniphest T113758

Convert DeleteAction.php/SpecialUndelete.php to use OOUI
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
Jdforrester-WMF
Sep 25 2015, 4:49 PM
Tags
Referenced Files
F8823400: Screenshot from 2017-07-23 16-34-29.png
Jul 23 2017, 11:36 PM
F8733228: image.png
Jul 13 2017, 5:34 PM
F8733232: image.png
Jul 13 2017, 5:34 PM
F8722644: image.png
Jul 12 2017, 8:24 PM
F8722649: image.png
Jul 12 2017, 8:24 PM
Subscribers
Aklapper
Esanders
Florian
gerritbot
Glaisher
Jdforrester-WMF
jeblad
View All 12 Subscribers

Description

BeforeAfter
image.png (968×1 px, 89 KB)
image.png (968×1 px, 91 KB)
image.png (968×1 px, 121 KB)
image.png (968×1 px, 122 KB)

Details

SubjectRepoBranchLines +/-
Convert rev preview on special:undelete to OOUImediawiki/coremaster+11 -6
Convert rest of Special:Undelete to OOUImediawiki/coremaster+94 -68
Convert article delete to use OOUImediawiki/coremaster+116 -63
Convert Special:Undelete search form to use OOUImediawiki/coremaster+52 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Sep 25 2015, 4:49 PM
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a project: UI-Standardization.
Jdforrester-WMF added subscribers: Legoktm, matmarex, Jdforrester-WMF and 3 others.
Volker_E moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Jan 18 2016, 11:26 PM
Esanders subscribed.May 9 2017, 3:51 PM

Partial dupe of T117794?

gerritbot subscribed.May 9 2017, 5:25 PM

Change 352863 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Convert article delete to use OOUI

https://gerrit.wikimedia.org/r/352863

gerritbot added a project: Patch-For-Review.May 9 2017, 5:25 PM
gerritbot added a comment.May 9 2017, 7:10 PM

Change 352874 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Convert Special:Undelete search form to use OOUI

https://gerrit.wikimedia.org/r/352874

Jdforrester-WMF added a subtask: T117794: Convert Special:RevisionDelete to OOUI.May 10 2017, 3:47 PM
In T113758#3248579, @Esanders wrote:

Partial dupe of T117794?

Adjusted parentage to make this work.

gerritbot added a comment.Jun 23 2017, 6:01 AM

Change 361026 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Convert rest of Special:Undelete to OOUI

https://gerrit.wikimedia.org/r/361026

gerritbot added a comment.Jul 12 2017, 3:51 PM

Change 352874 merged by jenkins-bot:
[mediawiki/core@master] Convert Special:Undelete search form to use OOUI

https://gerrit.wikimedia.org/r/352874

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 12 2017, 4:00 PM
gerritbot added a comment.Jul 12 2017, 4:14 PM

Change 352863 merged by jenkins-bot:
[mediawiki/core@master] Convert article delete to use OOUI

https://gerrit.wikimedia.org/r/352863

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 12 2017, 5:00 PM
gerritbot added a comment.Jul 12 2017, 7:02 PM

Change 361026 merged by jenkins-bot:
[mediawiki/core@master] Convert rest of Special:Undelete to OOUI

https://gerrit.wikimedia.org/r/361026

matmarex added a comment.Jul 12 2017, 7:55 PM

Let's consider RevisionDelete separately, it's an entirely different functionality (and we've done mostly everything else here, so it'd be nice not to block this task on that).

matmarex renamed this task from Convert DeleteAction.php/SpecialUndelete.php/SpecialRevisiondelete.php to use OOUI to Convert DeleteAction.php/SpecialUndelete.php to use OOUI.Jul 12 2017, 7:55 PM
matmarex removed a subtask: T117794: Convert Special:RevisionDelete to OOUI.
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)); removed MW-1.30-release-notes.Jul 12 2017, 8:00 PM
matmarex added a comment.Jul 12 2017, 8:24 PM

After the changes here:

image.png (968×1 px, 91 KB)

image.png (968×1 px, 122 KB)

The button and checkboxes at the bottom of Special:Undelete are unchanged. Is that in scope? (The same kind of button and checkboxes are shown e.g. on history pages, which are not OOUI yet, so we might want to leave that for later.)

Jdforrester-WMF closed this task as Resolved.Jul 12 2017, 8:36 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
In T113758#3432659, @matmarex wrote:

The button and checkboxes at the bottom of Special:Undelete are unchanged. Is that in scope? (The same kind of button and checkboxes are shown e.g. on history pages, which are not OOUI yet, so we might want to leave that for later.)

I was thinking of doing that with history pages, yes. They're all generated by HistoryListItemFactoryClassMaker.php or whatever, right?

Volker_E subscribed.Jul 12 2017, 8:37 PM
matmarex added a comment.Jul 12 2017, 8:45 PM

Looking at the code, it seems all of this is duplicated in
SpecialUndelete… I guess we might want to deal with that first.

Volker_E updated the task description. (Show Details)Jul 13 2017, 7:09 AM
matmarex updated the task description. (Show Details)Jul 13 2017, 5:34 PM
MarcoAurelio subscribed.Jul 23 2017, 11:04 PM

For future reference this has caused T171405. If you are working on more deletion or revdel OOUI-js conversion please do verify that all previous options still work. Thanks!

Legoktm added a comment.Jul 23 2017, 11:36 PM

Screenshot from 2017-07-23 16-34-29.png (590×991 px, 33 KB)

In MonoBook (using the Apex theme) the delete button looks like a lightish red on a white background, is that enough contrast to meet AA/AAA?

Volker_E added a comment.Jul 24 2017, 10:27 AM

@Legoktm Let's discuss this further in T171458: Create color sheet + WCAG evaluation of Apex

TheDJ added a subtask: T171455: Dropdown widgets on Special:Delete only has partial OOUI styling.Jul 24 2017, 3:10 PM
Trijnstel subscribed.Aug 12 2017, 1:43 PM
Shizhao mentioned this in T173997: Convert file delete to use OOUI.Aug 24 2017, 6:16 AM
gerritbot added a comment.Aug 25 2017, 5:14 PM

Change 373928 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Convert rev preview on special:undelete to OOUI

https://gerrit.wikimedia.org/r/373928

Restricted Application added a subscriber: jeblad. · View Herald TranscriptAug 25 2017, 5:14 PM
gerritbot added a project: Patch-For-Review.Aug 25 2017, 5:14 PM
gerritbot added a comment.Apr 22 2018, 11:24 AM

Change 373928 abandoned by Esanders:
Convert rev preview on special:undelete to OOUI

Reason:
Icb550a6ad8f90d7718441ec17a1026a2cfb9d754

https://gerrit.wikimedia.org/r/373928

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits








 ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://phabricator.wikimedia.org/T113758

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy