Content-Length: 114403 | pFad | http://phabricator.wikimedia.org/T190077
s| Esanders | |
| Mar 19 2018, 5:29 PM |
| F15885511: image.png | |
| Mar 19 2018, 5:34 PM |
If the revision ID has changed since the document was first opened, the user is more likely to be facing an edit conflict, and may have deliberately reloaded the page to get the latest wikitext. In this case we can prompt the user if they want to restore their changes, or load the document from scratch.
As discussed in T57370.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Autosave recovery prompt | mediawiki/extensions/VisualEditor | master | +46 -7 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Deskana | T189576 [Epic] Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) | |||
| Resolved | Esanders | T190077 Prompt user when restoring an auto-save against a new document version |
Change 419169 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Autosave recovery prompt
@matmarex
I was imagining a non-modal prompt, more like e.g. the find and replace "dialog".
@Volker_E
+1 to Bartosz' feedback
Similar to popup opening prevented feedback in Firefox.
I think blocking the editing of the document until the user chooses which version they want to edit makes sense. This is the same way Word/LibreOffice does document recovery, so will be familiar to users. It's also simpler from a technical & performance point of view.
I agree with Ed. It's not sensible to let users do other things before picking which document they're editing.
@Esanders Your comparison with Word/LibreOffice makes sense, let's see how the user feedback is.
Change 419169 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Autosave recovery prompt
Fetched URL: http://phabricator.wikimedia.org/T190077
Alternative Proxies:
