Content-Length: 117995 | pFad | http://phabricator.wikimedia.org/T382179

s ⚓ T382179 wikimedia/portals fails CI on Node 20
Page MenuHomePhabricator

wikimedia/portals fails CI on Node 20
Open, In Progress, MediumPublic

Description

https://integration.wikimedia.org/ci/job/generic-node20-browser/961/console

00:00:42.619 npm error In file included from ../../nan/nan.h:180,
00:00:42.619 npm error                  from ../src/common/allocator.cc:1:
00:00:42.619 npm error ../../nan/nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’
00:00:42.619 npm error    55 | typedef v8::Local<v8::AccessorSignature> Sig;
00:00:42.619 npm error       |                       ^~~~~~~~~~~~~~~~~
00:00:42.619 npm error ../../nan/nan_callbacks.h:55:40: error: template argument 1 is invalid
00:00:42.619 npm error    55 | typedef v8::Local<v8::AccessorSignature> Sig;
00:00:42.619 npm error       |                                        ^
00:00:42.619 npm error make: *** [iltorb.target.mk:144: Release/obj.target/iltorb/src/common/allocator.o] Error 1
00:00:42.619 npm error gyp ERR! build error 
00:00:42.619 npm error gyp ERR! stack Error: `make` failed with exit code: 2
00:00:42.619 npm error gyp ERR! stack at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:209:23)

This is blocking upgrading this repo to Node 20 in CI, and ultimately, dropping Node 18 from CI entirely, T343827.

Event Timeline

Change #1108399 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Rollback wikimedia-portals-build to Node 18

https://gerrit.wikimedia.org/r/1108399

Change #1108399 merged by jenkins-bot:

[integration/config@master] Rollback wikimedia-portals-build to Node 18

https://gerrit.wikimedia.org/r/1108399

Change #1108401 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Use node18-test image for Node 18

https://gerrit.wikimedia.org/r/1108401

Change #1108401 merged by jenkins-bot:

[integration/config@master] Use node18-test image for Node 18

https://gerrit.wikimedia.org/r/1108401

Jdlrobson changed the task status from Open to In Progress.Mon, Jan 6, 6:39 PM
Jdlrobson triaged this task as Medium priority.








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://phabricator.wikimedia.org/T382179

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy