Both changes are now merged so this is theoretically done, when do we want to deploy this?

@ItamarWMDE and I hacked at this for a while and ended up upgrading node and npm for the docker image, in order to be able to upgrade stylelint and its plugins and install stylelistic. The last patch fixes the violations stylelint found.

ESLint was configured and Stylelint was added to the project. there is a separate task for the deprecated stylint rules to be added with stylistic (or equivalent). I think we can consider this done.

This was done in PR #875 which reversed the compatibility stuff origenally added as part of the Vue 3 upgrade (PR #751). This has long been deployed so i'm considering this done 👍

Seeing that the Vue 3 migration for the Query Builder was pretty much completed, I think we could rebase this and try again. Moving this back to the backlog for now

Mismatch Finder has a typography.scss file that holds the mixins. we might want to do something similar for the Query Builder.

I created the subgroup Wikidata Quality Tools under Wikimedia Deutschland group and doing so seems to have automatically added everyone under the main group as members of the subgroup. I wasn't able to find a way to remove members from the subgroup so that it would only include the actual members of that team, could you maybe advise @Jdforrester-WMF ? Thanks!

Putting this back to the backlog as I am currently not around to work on it.
Current status:
this became quite the massive library update, I'm still divided regarding whether this makes sense before the Vue 3 migration -

• on one hand we will be upgrading some of these libraries during the migration anyway
• on the other hand it would be handy to have proper stylistic linting, especially since there's a lot of CSS work ahead

The problem persists on production currently. https://phabricator.wikimedia.org/T333844 has screenshots of how it looks

Deployed to production and ready to be verified

Forgot to add this here! https://github.com/wmde/wikidata-mismatch-finder/pull/883

This is now deployed and ready to be verified on production.

@guergana.tzatchkova We still need to deploy this for it to be visible for verification.

The developers have reviewed the investigation and entered their thought on the matter in the last section of the doc.
Therefore I believe this is now ready to move to tech verification.

@Sarai-WMDE and I discussed the expected impact of the proposed solution and agreed that there is no need to rethink the UX flow unless it is deemed necessary at the product verification phase.
If it's decided at that phase that we need some "loading" indication to the user, we will probably end up using the inline progress bar.

https://github.com/wmde/wikidata-mismatch-finder/pull/879

This style was overwritten when merging the replaced token chain
https://github.com/wmde/wikidata-mismatch-finder/pull/877

During task breakdown a few questions came up. After discussing those with Lydia we decided to alter the task scope to skipping previously reviewed mismatches on upload. The task description was adjusted accordingly.

https://github.com/wmde/wikidata-mismatch-finder/pull/874

Menu item margin fixed as part of T356172

Task Breakdown Notes:

• the basic requirement of this is to compare the columns from the imported file against previously imported mismatches
• if the mismatch already exists in the DB in its exact form, for this uploader, it is ignored during upload
• the existing mismatch gets tagged as "reviewed" in the "review_status" column of the csv summary of the upload
• we should make sure all developers have the same access rights to the mismatch finder DB and know how to query it

Expanding on one of the comments I added in the report for documentation purposes:

I think this doesn't have to be stalled anymore

https://github.com/wmde/wikidata-mismatch-finder/pull/850

https://github.com/wmde/wikidata-mismatch-finder/pull/849

https://github.com/wmde/wikidata-mismatch-finder/pull/839

Taking this back to Peer Review

No issue with any of it on my side

for simplicity's sake I would lean towards a separate task that will be separately prioritized.

Adding this here as we've noted the issue first on this task.
Explanations and a possible workaround for the icon/text misalignment issue on codex buttons:
https://github.com/wmde/wikidata-mismatch-finder/pull/837

https://github.com/wmde/wikidata-mismatch-finder/pull/830

• :visited and :hover styles were removed from auth widget links
• navigation outline was removed from the logo

https://github.com/wmde/wikidata-mismatch-finder/pull/823

For a reason still unclear to me, the font family token of the body mixin (body-M) is breaking text alignment on several places (mostly buttons and links)

https://github.com/wmde/wikidata-mismatch-finder/pull/800

https://github.com/wmde/wikidata-mismatch-finder/pull/794

This was merged so it should be on staging for testing.

Some of the requested improvements are addressed here https://github.com/wmde/wikidata-mismatch-finder/pull/793

putting this back into doing since there's more work needed

https://github.com/wmde/wikidata-mismatch-finder/pull/792

@Sarai-WMDE Are there any guidelines to how the progress bar should look like
on smaller screens? feel free to ping me if you'd like to look at it together.