[Babel 8] Change scope.{references,uids} to Set
#16624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57291 |
|
In fact, there are some potential problems with the current behavior. For example, when calling |
Comment on lines
395
to
402
| references?: Set<string>; | ||
| globals: { [name: string]: t.Identifier | t.JSXIdentifier }; | ||
| uids: { [name: string]: boolean }; | ||
| uids?: Set<string>; |
There was a problem hiding this comment.
Can you add a comment saying that they are only defined in the program scope? Or maybe, we can simplify some methods by defining them in all scopes but using the same shared set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2In addition to changing
scope.{references,uids}toSet, we also only create them at the top-level program scope, since we never use them in child scopes.I'm not sure if these two properties are public, but it would be good to mention it in the migration guide.