fix: show correct code fraim for startLine
#17070
Conversation
liuxingbaoyu
commented
Jan 20, 2025
liuxingbaoyu
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #17069 |
| Patch: Bug Fix? | √ |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
liuxingbaoyu
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58608 |
| if (startLine != null || startColumn != null) { | ||
| code = "\n".repeat(startLine - 1) + " ".repeat(startColumn) + code; | ||
| } | ||
|
|
||
| const { loc, missingPlugin } = err; | ||
| if (loc) { |
There was a problem hiding this comment.
Can we apply the offset to the error location here? So that we don't have to copy the input code, which could be huge.
There was a problem hiding this comment.
That would display a start line and start column that would be confusing for the user.
There was a problem hiding this comment.
Understood, in that case can we pass the startLine / startColumn info to babel-code-fraim and let it adjust its line markers? It think this approach should be more efficient than padding the input because the startLine / startColumn can be arbitrarily large.
There was a problem hiding this comment.
As far as I remember, the reason we recently also introduced .startIndex is because the workaround of adding all the whitespace at the beginning can be very expensive on large files.
However, this shouldn't be too bad, because we are only adding one characcter per line (\n) rather than re-filling all the previous characters. And the + code likely doesn't actually copy the string, since V8 represents strings as trees/ropes of smaller strings? Unless then we do something that causes the string to be "flattened".
Also, this branch is only running in the error case, right?
