[Babel 8] Parse export import = as an ExportNamedDeclaration
#17073
+1,301
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Breaking Change 💥
JLHwung
force-pushed
the
export-ts-import-equals
branch
from
a0efb71 to
f074683
Compare
10 tasks
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58612 |
JLHwung
commented
Jan 21, 2025
| @@ -2893,8 +2894,10 @@ export default (superClass: ClassWithMixin<typeof Parser, IJSXParserMixin>) => | |||
| ): N.AnyExport { | |||
| if (this.match(tt._import)) { | |||
| // `export import A = B;` | |||
| const nodeImportEquals = process.env.BABEL_8_BREAKING | |||
| ? this.startNode<N.TsImportEqualsDeclaration>() | |||
There was a problem hiding this comment.
Note that in Babel 8, TSImportEqualsDeclaration always starts with the import keyword, while the preceding export keyword starts the ExportNamedDeclaration.
JLHwung
commented
Jan 21, 2025
| !isExport && | ||
| (process.env.BABEL_8_BREAKING || | ||
| // @ts-ignore(Babel 7 vs Babel 8) Babel 7 AST | ||
| !stmt.node.isExport) && |
There was a problem hiding this comment.
Here we are checking top level statements, since a top-level TSImportEqualsDeclaration will be always an import declaration in Babel 8, we don't need the !isExport check here.
nicolo-ribaudo
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we parse the
TSImportEqualsDeclaration { isExport: true }as a vanillaTSImportEqualsDeclarationwithin anExportNamedDeclaration. TheisExportfield is therefore removed.