Ensured all Track 1 Key Vault libraries are removed. #43773
Conversation
vcolin7
requested review from
alzimmermsft,
samvaity,
JonathanGiles,
rujche,
Netyyyy,
saragluna,
moarychan,
a team,
hallipr,
weshaggard,
benbp and
JimSuplizio
as code owners
vcolin7
added
Client
|
@billwert, there does seem to be a problem with the find_unused_dependencies.py script. There are failures but it's not clear what the error is, the script just exits. |
The logs simply say: Maybe because the libraries I removed were the only ones using these 3 dependencies. I'll take a quick look and remove these lines if that's the case. |
|
Yup, 2 of the libraries I removed were using these and they're not being used anywhere else in the repo. The script did it's job well :) |
|
I've also disabled the pipelines related to |
|
/azp run java - core - ci |
|
/azp run java - template - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - keyvault - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
1 similar comment
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/checkenforcer override |
|
/check-enforcer override |
|
Overriding Check Enforcer since I'm removing a Track 1 pipeline (which should not run for this PR) and files in other paths are excluded from CI runs. |
That file was removed with PR #43773 so we need to stop trying to download it.
That file was removed with PR #43773 so we need to stop trying to download it.
A few months ago, @jairmyree removed a few of the Track 1 Key Vault libraries from the repository, as they had reached EOL and had been replaced by a new Track 2 offering.
This PR is just making sure we remove the rest of the libraries that meet the criteria, as well as any references to them in the repository other than being mentioned in CHANGELOGs or as external dependencies for a different library.
This PR also makes sure the CI pipelines for these libraries are effectively removed, as we won't be building them any longer and had been erroring out for a while now (see #42824).