-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: standardized unit testing with jest #10047
Conversation
e093c4d
to
2e64809
Compare
3e21499
to
1618c7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, noted a few questions here&there...
}, | ||
extensionsToTreatAsEsm: ['.ts'], | ||
moduleDirectories: ['node_modules'], | ||
moduleFileExtensions: ['ts', 'js', 'ios.ts'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we could run the whole test-suite twice, once against .ios.ts
and once against .android.ts
to cover all files...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for mentioning yes I am wanting to do this. Was considering two different configs and .spec.json that could be run independently for this.
PR Checklist
What is the current behavior?
Unit tests were awkward to work with and maintain.
What is the new behavior?
Unit tests are now easy to work with, use and maintain.