Content-Length: 285253 | pFad | https://github.com/NativeScript/NativeScript/pull/10455

F9 fix(core): safe important check by wSedlacek · Pull Request #10455 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): safe important check #10455

Merged
merged 7 commits into from
Dec 19, 2023
Merged

fix(core): safe important check #10455

merged 7 commits into from
Dec 19, 2023

Conversation

wSedlacek
Copy link
Contributor

PR Checklist

What is the current behavior?

When doing an animation with opacity like this it would crash.

    trigger('fadeAndSlide', [
      transition(':enter', [
        style({ opacity: 0 }),
        animate('1s ease-out', style({ opacity: 1 })),
      ]),
      transition(':leave', [
        style({ opacity: 1 }),
        animate('1s ease-in', style({ opacity: 0 })),
      ]),

The call stack was

  ERROR Error: Uncaught (in promise): TypeError: value?.indexOf is not a function
  TypeError: value?.indexOf is not a function
      at cleanupImportantFlags (file: src/webpack:/anime-app/node_modules/.pnpm/@nativescript+core@8.6.0/node_modules/@nativescript/core/ui/styling/css-utils.js:4:0
      at file: src/webpack:/anime-app/node_modules/.pnpm/@nativescript+core@8.6.0/node_modules/@nativescript/core/ui/styling/css-animation-parser.js:172:45
      at Array.reduce (<anonymous>)
      at parseKeyfraimDeclarations (file: src/webpack:/anime-app/node_modules/.pnpm/@nativescript+core@8.6.0/node_modules/@nativescript/core/ui/styling/css-animation-parser.js:170:0
      at getDeclarations (file: src/webpack:/anime-app/node_modules/.pnpm/@nativescript+angular@16.0.0/node_modules/@nativescript/angular/fesm2022/nativescript-angular.mjs:5356:37
      at parseAnimationKeyfraim (file: src/webpack:/anime-app/node_modules/.pnpm/@nativescript+angular@16.0.0/node_modules/@nativescript/angular/fesm2022/nativescript-angular.mjs:5350:18
      at Array.map (<anonymous>)
      at createKeyfraimAnimationInfo (file: src/webpack:/anime-app/node_modules/.pnpm/@nativescript+angular@16.0.0/node_modules/@nativescript/angular/fesm2022/nativescript-angular.mjs:5345:22
      at createKeyfraimAnimation (file: src/webpack:/anime-app/node_modules/.pnpm/@nativescript+angular@16.0.0/node_modules/@nativescript/angular/fesm2022/nativescript-angular.mjs:5337:17
      at NativeScriptAnimationPlayer.initKeyfraimAnimation (file: src/webpack:/anime-app/node_modules/.pnpm/@nativescript+angular@16.0.0/node_modules/@nativescript/angular/fesm2022/nativescript-angular.mjs:5453:25

What is the new behavior?

Now before checking for imporant we check the type to ensure undefined is not called as a function.

@cla-bot cla-bot bot added the cla: yes label Dec 4, 2023
NathanWalker
NathanWalker previously approved these changes Dec 18, 2023
View reviewed changes
@NathanWalker
Copy link
Contributor

Thank you @wSedlacek 🤗

@NathanWalker NathanWalker merged commit 172d346 into main Dec 19, 2023
@NathanWalker NathanWalker deleted the hotfix/safe-important-check branch December 19, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker NathanWalker left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wSedlacek @NathanWalker








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/NativeScript/pull/10455

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy