Content-Length: 264523 | pFad | https://github.com/NativeScript/NativeScript/pull/10618

E4 Revert "perf(core): avoid setting the same value to view properties" by CatchABus · Pull Request #10618 · NativeScript/NativeScript · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "perf(core): avoid setting the same value to view properties" #10618

Merged

NathanWalker merged 2 commits into NativeScript:main from CatchABus:revert-set-property-values

Oct 23, 2024

Contributor

CatchABus commented Sep 5, 2024

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

This reverts PR #10602 as those changes caused some issues. For more information, see discussion in #10602.


          Revert "perf(core): avoid setting the same value to view properties (N…

f9f4d36

…ativeScript#10602)"

This reverts commit 499fe8d.

CatchABus requested a review from rigor789

September 5, 2024 23:00

chimmelb commented Sep 16, 2024

Following. This affects us. (the background-color is not binding)

Contributor Author

CatchABus commented Oct 23, 2024

@NathanWalker @rigor789 This was supposed to revert faulty changes that unfortunately got included in 8.8.3. Can we include it at next version?

Contributor

NathanWalker commented Oct 23, 2024

We can include in 8.8.4 shortly, thanks @CatchABus


          Merge branch 'main' into revert-set-property-values

654c4f1

NathanWalker merged commit a320ca1 into NativeScript:main

0 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet