This change seems to have introduced an issue. The old code was working by accident, as it was never actually skipping anything because the condition would never be true:

delete oldProperties[property];
if (property in oldProperties && oldProperties[property] === value) {

Essentially because the old property is deleted before the condition, so it's always going to be checking for undefined === value...

But now that it actually skips, there's a problem, old and new value are somehow always the same, for example adding some logging, I see:

  skipping apply background-color
   - old rgba(241, 241, 255, 0.08)
   - new rgba(241, 241, 255, 0.08)
...
  skipping apply background
   - old linear-gradient(to right, #b21834, #860808)
   - new linear-gradient(to right, #b21834, #860808)

But the general issue/side-effect of this is that for example

<Label [ngClass]="{
  'bg-white': !showGradient(),
  'bg-gradient': showGradient()
}"></Label>

this should toggle between a white background-color and a gradient background, since these are separate properties, but it actually goes like this:

1. showGradient() === false -> bg-white - OK
2. showGradient() === true -> bg-gradient - OK
3. showGradient() === false -> no background, nor background-color - NOT OK

With Skip

Without Skip

@rigor789 Is it possible to share that sample? We can definitely revert it but before that, I'd like to see if we can find a solution because old code looked a bit weird.

@CatchABus sure, here's an example of the same setup: https://github.com/rigor789/style-bug-10602/blob/main/src/app/app.component.html

1. clone
2. ns debug ios --no-hmr
3. button is blue ✅
4. press button: button has gradient: ✅
5. press button again: button loses it's background: ❌
6. press button again: button has gradient: ✅

@CatchABus sure, here's an example of the same setup: https://github.com/rigor789/style-bug-10602/blob/main/src/app/app.component.html

1. clone
2. ns debug ios --no-hmr
3. button is blue ✅
4. press button: button has gradient: ✅
5. press button again: button loses it's background: ❌
6. press button again: button has gradient: ✅

@rigor789 Thanks, that helped a lot! I believe we should revert my PR for now due to how shorthand properties behave in core.
I have a good idea on how to improve handling for those properties and re-apply these changes at a later time. 😄