-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fibers #2411
Merged
Merged
Remove fibers #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsvetanMilanov
approved these changes
Jan 11, 2017
052f84a
to
0bd7b7b
Compare
run ci |
0bd7b7b
to
d6296f9
Compare
9985cca
to
dedf83a
Compare
This is a combination of 38 commits. Remove IFuture from function signatures - replace with async...Promise<T> Replace future wrapper in class-less functions Replace .wait with await Replace .wait with await vol 2 Replace .wait with await vol 3 Replace IFuture<T> with Promise<T> in .d.ts Replace Future.fromResult with async Mark IFuture functions without access modifiers as async Replace function..IFuture with async Promise ONE occurrence Mark execute functions as async...Promise<T> Mark lambdas as async Replace future.throw with reject Replace future.return with resolve Replace new Future with new Promise(resolve, reject) Revive lib/common Remove fibers from package.json Replace await return/await if with proper language Fix file in root of lib Fix lib/tools Fix lib/commands/plugin Fix lib/commands Fix files in lib/services up to test-execution-service.ts Fix all files in lib/providers Update package.json with required dependencies for testing. Fix tests from android-project-properties-manager to npm-support (inclusive) - all can be run successfully. Fix lib/device-sockets Fix test/platform-commands Fix services up until test-execution-service Fix test/platform-service Fix test/plugin-variables-service Fix test/lugins-service Fix test/project-commands Fix test/project-name-service Fix test/project-service test/project-templates-service Fix the rest of tests/ Fix error-reporting command Update dependencies, tsconfig and tslint rules Update dependencies required for transpilation. Update tsconfig with noUnusedLocals. Fix all files which have unused local variables in constructor. Update tslint rules. Add missing await in before/after prepare plugins Update ios-sim-portable to 2.0.0 Add missing await in doctor service
dedf83a
to
bd5a86d
Compare
bd5a86d
to
1535f08
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of 36 commits.
Remove IFuture from function signatures - replace with async...Promise
Replace future wrapper in class-less functions
Replace .wait with await
Replace .wait with await vol 2
Replace .wait with await vol 3
Replace IFuture with Promise in .d.ts
Replace Future.fromResult with async
Mark IFuture functions without access modifiers as async
Replace function..IFuture with async Promise ONE occurrence
Mark execute functions as async...Promise
Mark lambdas as async
Replace future.throw with reject
Replace future.return with resolve
Replace new Future with new Promise(resolve, reject)
Revive lib/common
Remove fibers from package.json
Replace await return/await if with proper language
Fix file in root of lib
Fix lib/tools
Fix lib/commands/plugin
Fix lib/commands
Fix files in lib/services up to test-execution-service.ts
Fix all files in lib/providers
Update package.json with required dependencies for testing. Fix tests from android-project-properties-manager to npm-support (inclusive) - all can be run successfully.
Fix lib/device-sockets
Fix test/platform-commands
Fix services up until test-execution-service
Fix test/platform-service
Fix test/plugin-variables-service
Fix test/lugins-service
Fix test/project-commands
Fix test/project-name-service
Fix test/project-service
test/project-templates-service
Fix the rest of tests/