CheckoutV2: Update logic to send payment id via options #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajawadmirza
force-pushed
the
SER-201_change_field
branch
from
2586e58 to
b7590d6
Compare
dsmcclain
suggested changes
Aug 1, 2022
There was a problem hiding this comment.
@ajawadmirza Thank you for making this change! I think we can still make it easier for the customer by consolidating the behavior into a single field, instead of two.
ajawadmirza
force-pushed
the
SER-201_change_field
branch
3 times, most recently
from
92686ee to
19a8a8f
Compare
ajawadmirza
force-pushed
the
SER-201_change_field
branch
from
19a8a8f to
7514d5c
Compare
Updated checkoutv2 to take payment id from options parameters instead of getting it as a payment method. SER-201 Remote: 72 tests, 186 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 5269 tests, 76156 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 746 files inspected, no offenses detected
ajawadmirza
force-pushed
the
SER-201_change_field
branch
from
7514d5c to
c30cba4
Compare
priorityspreedly
pushed a commit
to priorityspreedly/active_merchant
that referenced
this pull request
Aug 12, 2022
…nt#4518) Updated checkoutv2 to take payment id from options parameters instead of getting it as a payment method. SER-201 Remote: 72 tests, 186 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 5269 tests, 76156 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 746 files inspected, no offenses detected Co-authored-by: Nick Ashton <nashton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated checkoutv2 to take payment id from options parameters instead of getting it as a payment method.
SER-201
Remote:
72 tests, 186 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
5269 tests, 76156 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Rubocop:
746 files inspected, no offenses detected