Content-Length: 272172 | pFad | https://github.com/adafruit/circuitpython/pull/10145

80 Use MICROPY_HW_MCU_NAME for sysname and nodename for all ports. by eightycc · Pull Request #10145 · adafruit/circuitpython · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MICROPY_HW_MCU_NAME for sysname and nodename for all ports. #10145

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Use MICROPY_HW_MCU_NAME for sysname and nodename for all ports. #10145

merged 2 commits into from
Mar 20, 2025

Conversation

eightycc
Copy link
Collaborator

Use MICROPY_HW_MCU_NAME for os.uname().sysname and os.uname().nodename for all ports.

Resolves #9686.

@eightycc
Copy link
Collaborator Author

NB: This pull is intended for CP 10.0.0.

tannewt
tannewt requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these can be factored out into shared-module/os/__init__.c now. No need for so many copies of the same thing. Thanks for the PR!

@eightycc
Copy link
Collaborator Author

Factored common_hal_os_uname() into os_uname(). Removed common_hal_os_uname entirely. Testing:

Adafruit CircuitPython 9.2.4-318-g2f4cd7497d-dirty on 2025-03-20; Adafruit Feather RP2350 with rp2350a
>>> import os
>>> print(os.uname())
(sysname='rp2350a', nodename='rp2350a', release='9.2.4', version='9.2.4-318-g2f4cd7497d-dirty on 2025-03-20', machine='Adafruit Feather RP2350 with rp2350a')

@eightycc eightycc requested a review from tannewt March 20, 2025 14:14
tannewt
tannewt approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit e40b1f5 into adafruit:main Mar 20, 2025
611 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use MICROPY_HW_MCU_NAME for us.uname().sysname and .nodename
2 participants
@eightycc @tannewt








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/adafruit/circuitpython/pull/10145

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy