Fix signedness bug causing PIO hang-up. #10186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crash on deinit of incompletely initied state machine. Fix processor-dependent includes.
jepler
added a commit
that referenced
this pull request
Mar 26, 2025
This fixes an unlikely problem with the USB host implementation on rp2350 that would not have detected failure to allocate a DMA channel. Together with #10186 this should give a clean build. As it is, this will error.
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Mar 26, 2025
This fixes an unlikely problem with the USB host implementation on rp2350 that would not have detected failure to allocate a DMA channel. Together with adafruit#10186 this should give a clean build. As it is, this will error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed signed-ness bug in
State_Machine.c:use_existing_program()wherestate_machinewas unsigned but tested for less than 0. This was causing wrap-around indexing and other incorrect behavior resulting in a hang-up.Fixed processor-dependent includes that would cause RP2350 builds not to use third PIO.
Fixed hard-crash when de-initing PIO state machine that did not completely init due to exhaustion of PIO state machines.
Fixes #10157.