Print the Content-Length header only if it actually exists #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unsettling to see the "Content-Length" header printed in the diagnosis messages even though it is not actually present in the request and/or response headers. Note that we can't just test whether the `ContentLength` property is null or not because the [HttpContentHeaders.ContentLength implementation][1] automatically computes a value even if the Content-Length is not present. This is why using `content.Headers.TryGetValues` is mandatory. [1]: https://github.com/dotnet/runtime/blob/v8.0.5/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpContentHeaders.cs#L41-L55
adrianiftode
approved these changes
May 24, 2024
|
Thanks for merging a releasing a new version so quickly! 🚀 |
|
Thank you for taking the time to contribute to this library, really
appreciate it
…On Fri, May 24, 2024 at 7:34 PM Cédric Luthi ***@***.***> wrote:
Thanks for merging a releasing a new version so quickly! 🚀
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADI5U24Q2Y4V7TXCH7I6BCTZD6B4TAVCNFSM6AAAAABIH3FRFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZQGE2DIMJYGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
0xced
added a commit
to 0xced/FluentAssertions.Web
that referenced
this pull request
Sep 2, 2024
Pull request adrianiftode#122 accidentally introduced a potential NullReferenceException. Unfortunately the .NET Standard 2.0 assemblies don't have correct nullable annotations. `System.Net.Http.HttpRequestMessage.Content` is actually nullable and should be handled as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unsettling to see the "Content-Length" header printed in the diagnosis messages even though it is not actually present in the request and/or response headers.
Note that we can't just test whether the
ContentLengthproperty is null or not because the HttpContentHeaders.ContentLength implementation automatically computes a value even if the Content-Length is not present. This is why usingcontent.Headers.TryGetValuesis mandatory.