Content-Length: 395052 | pFad | https://github.com/angular/angular/issues/54284

7C Style guide updates · Issue #54284 · angular/angular · GitHub
Skip to content

Style guide updates #54284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JeanMeche opened this issue Feb 6, 2024 · 12 comments
Closed

Style guide updates #54284

JeanMeche opened this issue Feb 6, 2024 · 12 comments
Assignees
Labels
area: docs Related to the documentation P2 The issue is important to a large percentage of users, with a workaround
Milestone

Comments

@JeanMeche
Copy link
Member

JeanMeche commented Feb 6, 2024

Describe the problem that you experienced

This is an umbrella issue to report improvements that have been suggested for the style guide.

PRs

@MikaStark
Copy link

IMO, the style guide should be consistent with Angular Components coding standards (and vice-versa).

@Puigcerber
Copy link
Contributor

Hi @JeanMeche! Thank you for this, if I might add on top off the missing member sequence reported in #54341, it could be interesting to also add the sorting of lifecycle methods as currently implemented by sort-lifecycle-methods in @angular-eslint: after the constructor but before any other public method, and sorted in the same order they are called.

@salztorte
Copy link

Is there a timeline when the new style guide will be released?
It is a bit strange to explain to new people: "Yeah, in the guide is written that we should use this, but actually that is recommended."

@jelbourn
Copy link
Member

This one is on me! I've started drafting a new style guide and an RFC to go along with it, but keep getting pulled into other work related to support for Angular clients inside Google. I'm really hoping to get enough time to publish it for v19

@mylifeandcode
Copy link

mylifeandcode commented Aug 30, 2024

Thanks @jelbourn ! Hey, if you could give me a quick answer (if possible): is there ever a use case to keep using modules for a non-library project? I have several which make use of modules, but am not sure if converting them all to standalone is the right approach. I understand if this isn’t a quick or easy answer, but thought I’d ask. Thanks!

@jelbourn
Copy link
Member

jelbourn commented Aug 30, 2024

In general we're trying to move the ecosystem towards standalone over time for all cases. While we don't have any plans to deprecate or remove NgModule for the foreseeable future (for backwards compatibility), we do intend to emphasize them less and less.

@mylifeandcode
Copy link

mylifeandcode commented Sep 3, 2024

Thank you @jelbourn for the clarification! I’ll need to dive into the docs again for more info on lazy loading with standalone components. I know about lazy loading individual components, but like how you can lazy load a whole module’s worth with the module-driven approach. But at least I’m on the same page (pun intended) now. Thanks again!

@blyedev
Copy link

blyedev commented Oct 7, 2024

At the very end of the style guide angular recommends to use johpapa's snippets extension, which is wildly out of date with the ecosystem of angular itself and does not seem to be maintained with the velocity required to keep up with the changes in angular recommendations.

I'd argue the cli and the language server are far superior ways of scaffolding code, ensuring code style and quality.

I propose a change to either delete all snippet recommendations as nearly all of them have been barely updated over the last few years and don't show signs of life or replace them with the suggestion to use the cli for code scaffolding which is very prominent in the docs anyways.

@mylifeandcode
Copy link

At the very end of the style guide angular recommends to use johpapa's snippets extension, which is wildly out of date with the ecosystem of angular itself and does not seem to be maintained with the velocity required to keep up with the changes in angular recommendations.

I'd argue the cli and the language server are far superior ways of scaffolding code, ensuring code style and quality.

I propose a change to either delete all snippet recommendations as nearly all of them have been barely updated over the last few years and don't show signs of life or replace them with the suggestion to use the cli for code scaffolding which is very prominent in the docs anyways.

Seconded.

@jelbourn
Copy link
Member

There is now an RFC for the updated style guide: #58412

@mylifeandcode
Copy link

Thanks @jelbourn !

@JeanMeche
Copy link
Member Author

Updates in #60809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to the documentation P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

8 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/angular/angular/issues/54284

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy