-
Notifications
You must be signed in to change notification settings - Fork 26.1k
Style guide updates #54284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
IMO, the style guide should be consistent with Angular Components coding standards (and vice-versa). |
Hi @JeanMeche! Thank you for this, if I might add on top off the missing member sequence reported in #54341, it could be interesting to also add the sorting of lifecycle methods as currently implemented by sort-lifecycle-methods in @angular-eslint: after the constructor but before any other public method, and sorted in the same order they are called. |
Is there a timeline when the new style guide will be released? |
This one is on me! I've started drafting a new style guide and an RFC to go along with it, but keep getting pulled into other work related to support for Angular clients inside Google. I'm really hoping to get enough time to publish it for v19 |
Thanks @jelbourn ! Hey, if you could give me a quick answer (if possible): is there ever a use case to keep using modules for a non-library project? I have several which make use of modules, but am not sure if converting them all to standalone is the right approach. I understand if this isn’t a quick or easy answer, but thought I’d ask. Thanks! |
In general we're trying to move the ecosystem towards standalone over time for all cases. While we don't have any plans to deprecate or remove |
Thank you @jelbourn for the clarification! I’ll need to dive into the docs again for more info on lazy loading with standalone components. I know about lazy loading individual components, but like how you can lazy load a whole module’s worth with the module-driven approach. But at least I’m on the same page (pun intended) now. Thanks again! |
At the very end of the style guide angular recommends to use johpapa's snippets extension, which is wildly out of date with the ecosystem of angular itself and does not seem to be maintained with the velocity required to keep up with the changes in angular recommendations. I'd argue the cli and the language server are far superior ways of scaffolding code, ensuring code style and quality. I propose a change to either delete all snippet recommendations as nearly all of them have been barely updated over the last few years and don't show signs of life or replace them with the suggestion to use the cli for code scaffolding which is very prominent in the docs anyways. |
Seconded. |
There is now an RFC for the updated style guide: #58412 |
Thanks @jelbourn ! |
Updates in #60809 |
Describe the problem that you experienced
This is an umbrella issue to report improvements that have been suggested for the style guide.
inject()
#54220PRs
The text was updated successfully, but these errors were encountered: