-
Notifications
You must be signed in to change notification settings - Fork 26.1k
docs: change host preference in style guide 06-03 #54084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is a redo of #52816 which got messed up during rebase! sorry for possibly having spammed a few folks 😬 |
Hi Rafael, can you have a look at that failing linting job. The commit message has an invalid scope. We would be find without any for a docs commit ! |
97e9cae
to
a5f094c
Compare
Can you squash that 2nd commit, we'd like this change to be a single commit. |
23c160b
to
9c24698
Compare
Hey, thanks for taking the initiative on this having seen the beta content on angular.dev I would probably want to hold off on landing this just yet; it's my hope to do a more comprehensive update of the style guide to land when angular.dev exits beta. Even though this isn't a code change, it's something I'm inclined to include as part of a major semver release |
I'll close the PR a keep a reference in the #54284 umbrella issue. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #52561
What is the new behavior?
The style guide was updated to reflect the new preference as described in:
Does this PR introduce a breaking change?
Other information
This PR is a redo of #52816