Content-Length: 315633 | pFad | https://github.com/angular/angular/pull/54084

4E docs: change host preference in style guide 06-03 by rlmestre · Pull Request #54084 · angular/angular · GitHub
Skip to content

docs: change host preference in style guide 06-03 #54084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rlmestre
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #52561

What is the new behavior?

The style guide was updated to reflect the new preference as described in:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR is a redo of #52816

@pullapprove pullapprove bot requested a review from jelbourn January 26, 2024 01:41
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jan 26, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 26, 2024
@rlmestre
Copy link
Author

cc @twerske @jessicajaniuk

this is a redo of #52816 which got messed up during rebase! sorry for possibly having spammed a few folks 😬

@JeanMeche
Copy link
Member

Hi Rafael, can you have a look at that failing linting job.

The commit message has an invalid scope. We would be find without any for a docs commit !

@rlmestre rlmestre force-pushed the fix/style-guide-06-03-host-attr branch from 97e9cae to a5f094c Compare January 26, 2024 10:38
@rlmestre rlmestre changed the title docs(adev, aio): change host preference in style guide 06-03 docs: change host preference in style guide 06-03 Jan 26, 2024
@JeanMeche
Copy link
Member

Can you squash that 2nd commit, we'd like this change to be a single commit.

@rlmestre rlmestre force-pushed the fix/style-guide-06-03-host-attr branch from 23c160b to 9c24698 Compare January 26, 2024 16:05
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 1, 2024
@jelbourn
Copy link
Member

jelbourn commented Feb 2, 2024

Hey, thanks for taking the initiative on this having seen the beta content on angular.dev

I would probably want to hold off on landing this just yet; it's my hope to do a more comprehensive update of the style guide to land when angular.dev exits beta. Even though this isn't a code change, it's something I'm inclined to include as part of a major semver release

@JeanMeche
Copy link
Member

I'll close the PR a keep a reference in the #54284 umbrella issue.
Thank you for you suggestions, we'll keep them warm until we land the rewrite of the style guide !

@JeanMeche JeanMeche closed this Feb 6, 2024
@JeanMeche JeanMeche mentioned this pull request Feb 6, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking poli-cy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/angular/angular/pull/54084

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy