fix(service-worker): assign initializing client's app version, when a… #58131
+87
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: service-worker
rozpuszczalny
commented
Oct 9, 2024
| } else if (this.clientVersionMap.get(event.resultingClientId)! !== hash) { | ||
| throw new Error( | ||
| `Version mismatch between worker client ${event.resultingClientId} and requesting client ${clientId}`, | ||
| ); |
There was a problem hiding this comment.
I'm not sure if we should throw an error, or fallback to network via return null;
| } else if (this.clientVersionMap.get(event.resultingClientId)! !== this.latestHash) { | ||
| throw new Error( | ||
| `Version mismatch between worker client ${event.resultingClientId} and requesting client ${clientId}`, | ||
| ); |
There was a problem hiding this comment.
I'm not sure if we should throw an error, or fallback to network via return null;
rozpuszczalny
force-pushed
the
bugfix/57971-web-worker-version-mismatch
branch
from
35c5421 to
00f9e46
Compare
rozpuszczalny
force-pushed
the
bugfix/57971-web-worker-version-mismatch
branch
from
00f9e46 to
7a7acb7
Compare
rozpuszczalny
force-pushed
the
bugfix/57971-web-worker-version-mismatch
branch
from
7a7acb7 to
84d11f7
Compare
rozpuszczalny
force-pushed
the
bugfix/57971-web-worker-version-mismatch
branch
from
84d11f7 to
5d1e997
Compare
thePunderWoman
approved these changes
Apr 2, 2025
thePunderWoman
added
action: merge
… request is for worker script When a new version of app is available in a service worker, and a client with old version exists, web workers initialized from a client with old version will now be properly assigned with the same version. Before this change, a web worker was assigned with the newest version. Fixes angular#57971
thePunderWoman
force-pushed
the
bugfix/57971-web-worker-version-mismatch
branch
from
5d1e997 to
d9b0ad3
Compare
thePunderWoman
pushed a commit
that referenced
this pull request
Apr 2, 2025
… request is for worker script (#58131) When a new version of app is available in a service worker, and a client with old version exists, web workers initialized from a client with old version will now be properly assigned with the same version. Before this change, a web worker was assigned with the newest version. Fixes #57971 PR Close #58131
|
This PR was merged into the repository by commit 4546d4f. The changes were merged into the following branches: main, 19.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… request is for worker script
When a new version of app is available in a service worker, and a client with old version exists, web workers initialized from a client with old version will now be properly assigned with the same version.
Before this change, a web worker was assigned with the newest version.
Fixes #57971
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #57971
What is the new behavior?
When a web worker script request is made to a service worker, it gets assigned the same version as the tab that created it.
Does this PR introduce a breaking change?
No, unless someone was relying on a faulty behavior
Other information