Content-Length: 309542 | pFad | https://github.com/angular/angular/pull/60376

94 fix(compiler-cli): Produce fatal diagnostic on duplicate decorated pr… by atscott · Pull Request #60376 · angular/angular · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): Produce fatal diagnostic on duplicate decorated pr… #60376

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Mar 13, 2025

…operties

This prevents the compilation and language service from crashing.

fixes angular/vscode-ng-language-service#2091

@atscott atscott added the target: patch This PR is targeted for the next patch release label Mar 13, 2025
@atscott atscott requested a review from crisbeto March 13, 2025 18:03
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 13, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 13, 2025
…operties

This prevents the compilation and language service from crashing.

fixes angular/vscode-ng-language-service#2091
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from mmalerba March 17, 2025 10:23
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 27, 2025
@thePunderWoman thePunderWoman removed the request for review from alxhub March 27, 2025 19:46
thePunderWoman pushed a commit that referenced this pull request Mar 27, 2025
…operties (#60376)

This prevents the compilation and language service from crashing.

fixes angular/vscode-ng-language-service#2091

PR Close #60376
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 5948cd0.

The changes were merged into the following branches: main, 19.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language server crash on duplicate decorated properties
5 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/angular/angular/pull/60376

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy