fix(core): preserve comments in internal inject migration #60588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal-only combineMemberInitializers option for the inject migration sometimes dropped the doc comments from the members.
RussellSprouts
commented
Mar 27, 2025
| ``, | ||
| `@Directive()`, | ||
| `class MyDir {`, | ||
| ` private foo = inject(Foo);`, |
There was a problem hiding this comment.
My code here loses the whitespace (e.g., blank lines) around the members, which isn't ideal. Let me know if you know of a good way to preserve it.
There was a problem hiding this comment.
Since this is internal-only and we apply auto-formatting, I think it's okay.
jelbourn
added
target: patch
crisbeto
approved these changes
Mar 27, 2025
| ``, | ||
| `@Directive()`, | ||
| `class MyDir {`, | ||
| ` private foo = inject(Foo);`, |
There was a problem hiding this comment.
Since this is internal-only and we apply auto-formatting, I think it's okay.
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 27, 2025
The internal-only combineMemberInitializers option for the inject migration sometimes dropped the doc comments from the members. PR Close #60588
|
This PR was merged into the repository by commit 0cd7d3b. The changes were merged into the following branches: main, 19.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal-only combineMemberInitializers option for the inject migration sometimes dropped the
doc comments from the members.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information