Fixes for the inject migration #60602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nced via this The inject migration has some logic that treats parameters referenced directly inside of `super` differently. This logic didn't account for the fact that the parameters could be inside of inline functions which have less strict access requirements.
Fixes that the logic which checks whether a parameter is used inside a `super` call wasn't accounting for shorthand assignments.
crisbeto
added
action: review
angular-robot
bot
added
the
area: migrations
devversion
approved these changes
Mar 28, 2025
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 0c53970. The changes were merged into the following branches: main, 19.2.x |
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 28, 2025
Fixes that the logic which checks whether a parameter is used inside a `super` call wasn't accounting for shorthand assignments. PR Close #60602
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 28, 2025
Fixes that the logic which checks whether a parameter is used inside a `super` call wasn't accounting for shorthand assignments. PR Close #60602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues in the
injectmigration that came up internally.fix(migrations): inject migration not handling super parameter referenced via this
The inject migration has some logic that treats parameters referenced directly inside of
superdifferently. This logic didn't account for the fact that the parameters could be inside of inline functions which have less strict access requirements.fix(migrations): handle shorthand assignments in super call
Fixes that the logic which checks whether a parameter is used inside a
supercall wasn't accounting for shorthand assignments.