Content-Length: 287775 | pFad | https://github.com/angular/components/pull/31165#event-17776779509

84 fix(material/sort): simplify m2 sort color by andrewseguin · Pull Request #31165 · angular/components · GitHub
Skip to content

fix(material/sort): simplify m2 sort color #31165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

andrewseguin
Copy link
Contributor

Sort icon used to be a mix of different elements, and opacity would cause problems. This is no longer the case

Sort color should just match "text" which is what the table header label does

@andrewseguin andrewseguin requested a review from a team as a code owner May 21, 2025 01:24
@andrewseguin andrewseguin requested review from mmalerba and ok7sai and removed request for a team May 21, 2025 01:24
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label May 21, 2025
Copy link
Contributor

@ok7sai ok7sai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the unused color and meta imports?

Andrew Seguin added 2 commits May 22, 2025 11:08
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 22, 2025
@andrewseguin andrewseguin merged commit d22191a into angular:main May 22, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/sort target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/angular/components/pull/31165#event-17776779509

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy