Content-Length: 271606 | pFad | https://github.com/apache/iceberg/pull/4965

69 Fix :iceberg-api:revapi failure - allow the new method by findepi · Pull Request #4965 · apache/iceberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix :iceberg-api:revapi failure - allow the new method #4965

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Fix :iceberg-api:revapi failure - allow the new method #4965

merged 1 commit into from
Jun 6, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Jun 6, 2022

Before the change, a build run locally with

./gradlew -x test -x integrationTest clean build

would fail at the :iceberg-api:revapi task.

@findepi
Fix :iceberg-api:revapi failure - allow the new method
4ee93a3 
Before the change, a build run locally with

    ./gradlew -x test -x integrationTest clean build

would fail at the :iceberg-api:revapi task.
@findepi
Copy link
Member Author

findepi commented Jun 6, 2022

Per @ajantha-bhat 's comment https://apache-iceberg.slack.com/archives/C025PH0G1D4/p1654519428401729?thread_ts=1654517622.709609&cid=C025PH0G1D4, the :iceberg-api:revapi gets SKIPPED when run on master branch from the api-binary-compatibility.yml` workflow.

Example in currently last run on the master branch: https://github.com/apache/iceberg/runs/6747965003?check_suite_focus=true

perhaps same or similar problem applies to the PR builds.

@ajantha-bhat
Copy link
Member

@findepi : Thanks for the Fix. But better fix the CI task (github actions of rev api) to catch it before merging this? Else some other new PR might produce new issue and we keep on fixing it.

@findepi
Copy link
Member Author

findepi commented Jun 6, 2022

But better fix the CI task (github actions of rev api) to catch it before merging this?

Good idea, someone should look into that.

@findepi findepi requested review from danielcweeks and kbendick June 6, 2022 12:49
@rdblue rdblue merged commit c9efc4b into apache:master Jun 6, 2022
@findepi findepi deleted the findepi/fix-iceberg-api-revapi-failure-allow-the-new-method-4a79fe branch June 6, 2022 18:45
@wypoon wypoon mentioned this pull request Jun 6, 2022
Merged
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
@findepi
API: Fix revapi failure, allow BoudnTerm.isEquivalentTo (apache#4965)
73fd66b
namrathamyske pushed a commit to namrathamyske/iceberg that referenced this pull request Jul 10, 2022
@findepi
API: Fix revapi failure, allow BoudnTerm.isEquivalentTo (apache#4965)
5d5bdd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdblue rdblue rdblue approved these changes

@danielcweeks danielcweeks Awaiting requested review from danielcweeks

@kbendick kbendick Awaiting requested review from kbendick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @ajantha-bhat @rdblue








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/apache/iceberg/pull/4965

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy