feat(dap)!: support integrated terminals (io in neovim) #877

Jint-lzxy · 2023-07-19T12:39:39Z

Recent updates to nvim-dap made integrated terminals possibe right inside Neovim. This PR implemented basic support for this feature, but it's still necessary to adjust the settings of each debugger to correctly redirect stdio to the specified terminal (inside Neovim). More info: dap-terminal.

I'm not that familiar with other debuggers so I only adjusted the settings for codelldb (AFAIK lldb-vscode has zero support for IO redirection). Someone who understands these other debuggers could help make several changes before merging :) Any help will be appreciated!

Aditionally, K (responsible for require('dapui').eval()) will be set as a buffer-local keymap (mode: n|v) when a session initiates. We may need to document this in the Wiki.

Related: #416, #440, #592

ayamir · 2023-07-20T04:49:16Z

It's ok for codelldb 👍

ayamir · 2023-07-20T05:07:01Z

Works for debugpy.

ayamir · 2023-07-20T05:22:06Z

delve and lldb-vscode doesn't support this feature.

mfussenegger/nvim-dap#763
mfussenegger/nvim-dap#458 (comment)

Jint-lzxy · 2023-07-20T06:27:54Z

@ayamir vscode-go seems to support that but this require users to compile the corresponding executables themselves.

EDIT: Just noticed that Mason has a registry entry go-debug-adapter.

Jint-lzxy · 2023-07-20T08:27:58Z

35ec0f0

Jint-lzxy · 2023-07-20T09:17:34Z

Doesn't work on my machine...

Hmmm maybe open an issue upstream at nvim-dap? I'm not that familiar with delve so probably can't help with this :

The document indicates that setting console = "integratedTerminal" is supported 🤔

ayamir · 2023-07-20T09:18:26Z

Doesn't work on my machine...

VSCode is ok.

ayamir · 2023-07-20T09:42:13Z

Hmmm maybe open an issue upstream at nvim-dap?

mfussenegger/nvim-dap#987

fix variable naming

CharlesChiuGit · 2023-07-22T13:55:37Z

sorry for the late reply, quite busy these couple weeks. i'll review this pr on following next week days.

Jint-lzxy · 2023-07-22T15:51:46Z

sorry for the late reply, quite busy these couple weeks. i'll review this pr on following next week days.

No worries and no hurry! Review this whenever it's convenient for you 😄

CharlesChiuGit

LGTM

~~But I don't know how to toggle to dap terminal tho~~

Jint-lzxy · 2023-07-24T08:09:15Z

But I don't know how to toggle to dap terminal tho

@CharlesChiuGit Move ur cursor to the buffer named [dap-terminal] <profile-name> (bottom left corner), enter insert mode and use that like a normal terminal (stdin and stdout are connected to that buffer if supported)

CharlesChiuGit · 2023-07-24T08:16:05Z

I only get this after I press <F6> to open terminal?

didn't see the dap-terminal buffer.

Jint-lzxy · 2023-07-24T08:19:30Z

didn't see the dap-terminal buffer.

Hmm that's strange. The effective component is (dapui):

{
	elements = {
		{ id = "console", size = 0.55 },
		{ id = "repl", size = 0.45 },
	},
	position = "bottom",
	size = 0.25,
},

Restart Neovim and sync those plugins to see if this helps?

CharlesChiuGit · 2023-07-24T08:42:01Z

aha, I accidentally removed that part. Now it's working! tks!

CharlesChiuGit · 2023-07-27T08:04:00Z

is this pr gd to go?

Jint-lzxy · 2023-07-27T08:10:55Z

Currently waiting for mfussenegger/nvim-dap#987, cause I'm not sure if Go-related stuffs are good to go yet.

CharlesChiuGit · 2023-07-27T08:27:19Z

hmmm, the author just closed the issue as not planned.

Jint-lzxy · 2023-07-27T08:33:03Z

hmmm, the author just closed the issue as not planned.

Yeah that's indeed a tricky one. I'm drafting a new release note and will briefly cover this. I will merge this once Im done ;)

* feat(dap)!: support integrated terminals (io in neovim) * fix(dap): correct event callback * feat(dap): setup keymaps correctly * fix CI fix variable naming * adjust dapui * feat(dap): support debugpy integrated terminal io. * support vscode-go and misc changes * fix CI * fixup dap utils --------- Co-authored-by: ayamir <lgt986452565@gmail.com>

Jint-lzxy requested review from CharlesChiuGit and ayamir July 19, 2023 12:39

Jint-lzxy force-pushed the feat/dap-integrated-terminal branch 2 times, most recently from a9f1103 to 3f24b6f Compare July 19, 2023 17:54

ayamir approved these changes Jul 20, 2023

View reviewed changes

Jint-lzxy and others added 8 commits July 21, 2023 17:32

feat(dap)!: support integrated terminals (io in neovim)

4f49d22

fix(dap): correct event callback

2d4c928

feat(dap): setup keymaps correctly

d19a334

fix CI

c6c7af5

fix variable naming

adjust dapui

a3f9e61

feat(dap): support debugpy integrated terminal io.

78c10a3

support vscode-go and misc changes

8dc3643

fix CI

81c022b

Jint-lzxy force-pushed the feat/dap-integrated-terminal branch from 1ab02c9 to 81c022b Compare July 21, 2023 09:32

CharlesChiuGit approved these changes Jul 24, 2023

View reviewed changes

fixup dap utils

022d222

Jint-lzxy merged commit a961024 into main Jul 27, 2023

Jint-lzxy deleted the feat/dap-integrated-terminal branch July 27, 2023 09:28

Jint-lzxy mentioned this pull request Jul 27, 2023

The mapping does not work as designed in debug mode #899

Closed

2 tasks

TonyWu20 mentioned this pull request Jul 28, 2023

ayamir main TonyWu20/nvimdots#24

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dap)!: support integrated terminals (io in neovim) #877

feat(dap)!: support integrated terminals (io in neovim) #877

Jint-lzxy commented Jul 19, 2023 •

edited

Loading

ayamir commented Jul 20, 2023

ayamir commented Jul 20, 2023

ayamir commented Jul 20, 2023 •

edited

Loading

Jint-lzxy commented Jul 20, 2023 •

edited

Loading

Jint-lzxy commented Jul 20, 2023

Jint-lzxy commented Jul 20, 2023

ayamir commented Jul 20, 2023

ayamir commented Jul 20, 2023

CharlesChiuGit commented Jul 22, 2023

Jint-lzxy commented Jul 22, 2023

CharlesChiuGit left a comment •

edited

Loading

Jint-lzxy commented Jul 24, 2023

CharlesChiuGit commented Jul 24, 2023

Jint-lzxy commented Jul 24, 2023

CharlesChiuGit commented Jul 24, 2023 •

edited

Loading

CharlesChiuGit commented Jul 27, 2023

Jint-lzxy commented Jul 27, 2023

CharlesChiuGit commented Jul 27, 2023 •

edited

Loading

Jint-lzxy commented Jul 27, 2023

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

feat(dap)!: support integrated terminals (io in neovim) #877

feat(dap)!: support integrated terminals (io in neovim) #877

Conversation

Jint-lzxy commented Jul 19, 2023 • edited Loading

ayamir commented Jul 20, 2023

ayamir commented Jul 20, 2023

ayamir commented Jul 20, 2023 • edited Loading

Jint-lzxy commented Jul 20, 2023 • edited Loading

Jint-lzxy commented Jul 20, 2023

Jint-lzxy commented Jul 20, 2023

ayamir commented Jul 20, 2023

ayamir commented Jul 20, 2023

CharlesChiuGit commented Jul 22, 2023

Jint-lzxy commented Jul 22, 2023

CharlesChiuGit left a comment • edited Loading

Choose a reason for hiding this comment

Jint-lzxy commented Jul 24, 2023

CharlesChiuGit commented Jul 24, 2023

Jint-lzxy commented Jul 24, 2023

CharlesChiuGit commented Jul 24, 2023 • edited Loading

CharlesChiuGit commented Jul 27, 2023

Jint-lzxy commented Jul 27, 2023

CharlesChiuGit commented Jul 27, 2023 • edited Loading

Jint-lzxy commented Jul 27, 2023

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

Jint-lzxy commented Jul 19, 2023 •

edited

Loading

ayamir commented Jul 20, 2023 •

edited

Loading

Jint-lzxy commented Jul 20, 2023 •

edited

Loading

CharlesChiuGit left a comment •

edited

Loading

CharlesChiuGit commented Jul 24, 2023 •

edited

Loading

CharlesChiuGit commented Jul 27, 2023 •

edited

Loading