This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: take experimentalAPI into account in getClient #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getClient() has not taken into account the case of !experimentalAPI, before calling registryClient. It has set endPoint to a specific value of URLs, but the new value would not be passed to getRegistryClient(), which simply fetches endPoint again. This was a regression since 848d356 ("fleetctl: convert cli to cobra"). To fix that, introduce getEndpoint() that does GetString("endpoint") as well as the special handling for experimentalAPI. And make getRegistryClient() call getEndpoint(). Fortunately, the experimentalAPI flag is set to true by default, so this special handling path is not actively used after all. Just for correctness.
dongsupark
force-pushed
the
dongsu/fleetctl-fix-get-endpoint
branch
from
10db98f to
85d1d29
Compare
|
I just manually tested it, and I confirm that it fixes the regression. It works fine now. |
dongsupark
pushed a commit
that referenced
this pull request
Nov 10, 2016
fleetctl: take experimentalAPI into account in getClient
dongsupark
pushed a commit
that referenced
this pull request
Nov 10, 2016
fleetctl: take experimentalAPI into account in getClient
dongsupark
pushed a commit
that referenced
this pull request
Nov 10, 2016
fleetctl: take experimentalAPI into account in getClient
|
lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getClient()has not taken into account the case of!experimentalAPI, before calling registryClient. It has set endPoint to a specific value of URLs, but the new value would not be passed togetRegistryClient(), which simply fetches endPoint again. This was a regression since 848d356 ("fleetctl: convert cli to cobra").To fix that, introduce
getEndpoint()that does GetString("endpoint") as well as the special handling for experimentalAPI. And makegetRegistryClient()callgetEndpoint().Fortunately, the experimentalAPI flag is set to true by default, so this special handling path is not actively used after all. Just for correctness.