-
Notifications
You must be signed in to change notification settings - Fork 28.9k
WebParagraph initial commit #167559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
WebParagraph initial commit #167559
+2,161
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the test file
Test still not working
Drawing paragraph on Canvas2D (not working)
Drawing paragraph on Canvas2D (not working)
Drawing paragraph on Canvas2D (not working)
on DrawImage
No bidi, no hard line breaks
(Required flattening the style ranges)
(it breaks but somewhere down the road)
All tests workin
mdebbar
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed some things and added TODOs for others in order to avoid massive conflicts with the upcoming PR: #168412
This code is still inaccessible from normal Flutter.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 21, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 21, 2025
flutter/flutter@70a3c3c...70cdc0c 2025-07-21 Rusino@users.noreply.github.com WebParagraph initial commit (flutter/flutter#167559) 2025-07-21 engine-flutter-autoroll@skia.org Roll Dart SDK from a821b47e7a4d to da9e0299c120 (1 revision) (flutter/flutter#172457) 2025-07-21 kjlubick@users.noreply.github.com [skia] Update call to SkImage::makeSubset (flutter/flutter#172456) 2025-07-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8MyOdk7FEK-MqkzIF... to a_55b5hqpRnigzuNC... (flutter/flutter#172439) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: text input
Entering text in a text field or keyboard related problems
engine
flutter/engine repository. See also e: labels.
platform-web
Web applications specifically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the current (initial) state of WebParagraph project which is an implementation of SkParagraph
on top of TextCluster (https://github.com/fserb/canvas2D/blob/master/spec/enhanced-textmetrics.md).
Multilined text, mixed LTR/RTL text supported.
Part of #172561