Content-Length: 489711 | pFad | https://github.com/flutter/flutter/pull/167559

21 WebParagraph initial commit by Rusino · Pull Request #167559 · flutter/flutter · GitHub
Skip to content

WebParagraph initial commit #167559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 79 commits into from
Jul 21, 2025
Merged

WebParagraph initial commit #167559

merged 79 commits into from
Jul 21, 2025

Conversation

Rusino
Copy link
Contributor

@Rusino Rusino commented Apr 22, 2025

This is the current (initial) state of WebParagraph project which is an implementation of SkParagraph
on top of TextCluster (https://github.com/fserb/canvas2D/blob/master/spec/enhanced-textmetrics.md).

Multilined text, mixed LTR/RTL text supported.

Part of #172561

@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Apr 22, 2025
@mdebbar mdebbar removed the a: text input Entering text in a text field or keyboard related problems label Jun 26, 2025
@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Jun 27, 2025
@mdebbar mdebbar self-requested a review July 17, 2025 19:50
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some things and added TODOs for others in order to avoid massive conflicts with the upcoming PR: #168412

This code is still inaccessible from normal Flutter.

LGTM!

@mdebbar mdebbar changed the title WebParagraph implementation WebParagraph initial commit Jul 18, 2025
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 21, 2025
Merged via the queue into flutter:master with commit 70cdc0c Jul 21, 2025
175 of 176 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 21, 2025
flutter/flutter@70a3c3c...70cdc0c

2025-07-21 Rusino@users.noreply.github.com WebParagraph initial commit (flutter/flutter#167559)
2025-07-21 engine-flutter-autoroll@skia.org Roll Dart SDK from a821b47e7a4d to da9e0299c120 (1 revision) (flutter/flutter#172457)
2025-07-21 kjlubick@users.noreply.github.com [skia] Update call to SkImage::makeSubset (flutter/flutter#172456)
2025-07-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8MyOdk7FEK-MqkzIF... to a_55b5hqpRnigzuNC... (flutter/flutter#172439)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. platform-web Web applications specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/flutter/flutter/pull/167559

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy