Content-Length: 291220 | pFad | https://github.com/foundation/foundation-sites/pull/10827

50 fix: remove tab outline when not using keyboard 10798 by ncoden · Pull Request #10827 · foundation/foundation-sites · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove tab outline when not using keyboard 10798 #10827

Merged
merged 1 commit into from
Dec 30, 2017
Merged

fix: remove tab outline when not using keyboard 10798 #10827

merged 1 commit into from
Dec 30, 2017

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Dec 29, 2017

No outline should be show when it is not for accessibility reasons, since it is not part of the Foundation design. So when what-input detect a mouse, we should have outline: 0; on the tab links

Closes #10798

Owlbertz
Owlbertz suggested changes Dec 30, 2017
View reviewed changes
Copy link
Contributor

@Owlbertz Owlbertz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncoden I guess your modifications of the Reveal SCSS-files in this PR are a mistake?

@ncoden
Copy link
Contributor Author

ncoden commented Dec 30, 2017

@Owlbertz Yes it is

@ncoden ncoden force-pushed the fix/remove-tab-outline-on-mouse-10798 branch from 280fa98 to 856cf61 Compare December 30, 2017 22:20
@ncoden
Copy link
Contributor Author

ncoden commented Dec 30, 2017

@Owlbertz I fixed this.

Owlbertz
Owlbertz approved these changes Dec 30, 2017
View reviewed changes
Copy link
Contributor

@Owlbertz Owlbertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@ncoden ncoden merged commit fab9014 into foundation:develop Dec 30, 2017
@ncoden ncoden deleted the fix/remove-tab-outline-on-mouse-10798 branch April 7, 2018 17:45
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#10827 from ncoden/fix/remove-tab-outline-…
469a24a 
…on-mouse-10798 for v6.5.0

856cf61 fix: remove tab outline on mouse foundation#10798

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Owlbertz Owlbertz Owlbertz approved these changes

Assignees
No one assigned
Labels
bug fix Tabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncoden @Owlbertz








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/foundation/foundation-sites/pull/10827

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy