-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: duplicate package paths in export data manifest (via telemetry) #63822
Comments
Change https://go.dev/cl/560795 mentions this issue: |
This change pushes the assertions more deeply into the type checking logic so that we might have a chance of understanding the recurring inconsistency problems reported by telemetry. Updates golang/go#63822 Change-Id: I1371f7aa7104df0c55e055a11e9e6bb15219d79a Reviewed-on: https://go-review.googlesource.com/c/tools/+/560795 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>
The "inconsistent view of dependencies" assertion was hit: This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
This stack
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. |
I believe I know what this may be, having been looking more closely at our loading logic. I think this can happen when there are on-disk file changes that gopls does not observe, and one branch of the package tree is invalidated while the other isn't. I also have an idea for a fix. Will try to get this in for v0.17.0. |
Change https://go.dev/cl/628495 mentions this issue: |
The most likely cause of an inconsistent view of a dependency is a mismatching test variant. Refine the bug report to identify this case. For golang/go#63822 Change-Id: I1334501be1ea55a43a49557ad2cb1d03178268cc Reviewed-on: https://go-review.googlesource.com/c/tools/+/628495 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The most recent stack comes from a refinement:
|
Change https://go.dev/cl/647515 mentions this issue: |
This stack
|
Telemetry data at https://storage.googleapis.com/prod-telemetry-merged/2023-10-28.json clearly demonstrates a package that cannot be imported: there are in fact two bug reports, one each in type checking (#64235) and analysis (#64236).
Clearly some invariant is being violated. We should use the reportf callback passed into the importer to get a more accurate stack, as otherwise this is unlikely to be actionable (we can't see the error message in telemetry, which we probably didn't consider when adding this instrumentation).
Putting this in the v0.14.2 milestone as it would be nice to get to the bottom of this error. I'll push down the instrumentation.
CC @adonovan
Dups: BQtcLQ m5UK3A W_lHAg du4kbA PDrh5Q jZbDKQ 4elxTA JhOH0g oat8ig wr44gQ 6j0bvA 9wAdDQ 6LjVfg A3ISjw nJQxXw tQYZmg vx_wYg BQtcJQ WpB6LA WzmCgg DetyaA yimcvw y4xHuQ 0JP54Q -trCvQ fuzfjQ w2_GEQ 3_R2tA 3_R2vA iBh0rw m44AmQ CYJxZw WUTC9w nPNE0A 5I0Kxw kVgEzw
Dups for which I can't be bothered to include the stack: rPGxIQ _ZJXvw VJTMTw hCJB7Q 1xF43w nPNE0A m9MmHA SQT0sg TwtkSg
Dups: BWn-Aw 8nKERA YQKCXA xOe7BQ y7CqCA 3ue-nQ cYxHdQ PQst8g Jm14RQ eFV2uQ cIxFiw lZ85Ug ovScmQ eZ-Gkw h1dggQ hViEvg DUHIGA zw0_tw UlyTiA yg0dyA Msz07g Qmgupw 8kQsoA VUMLHA lNJ2zw n4vZqA isQrRw K-rZ-A 0DqsTg nT0dHQ
The text was updated successfully, but these errors were encountered: