Content-Length: 255898 | pFad | https://github.com/google/ExoPlayer/issues/9472

36 h262 support codec tag · Issue #9472 · google/ExoPlayer · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h262 support codec tag #9472

Closed
emveepee opened this issue Sep 23, 2021 · 5 comments
Closed

h262 support codec tag #9472

emveepee opened this issue Sep 23, 2021 · 5 comments
Assignees
@kim-vde
Labels
bug

Comments

@emveepee
Copy link

Is there a way to modify the codec tag support for h262 files in software without changing the core library? A user has provided several video samples from the US with CableCard mpeg2video that have 0x80 in the codec_tag. Exoplayer default does not detect video or flag a warning that video isn't support by the player. Video will play if I hard-code this in DefaultTsPayloadReaderFactory

      case TsExtractor.TS_STREAM_TYPE_H262:
      case 0x80:
        return new PesReader(new H262Reader(buildUserDataReader(esInfo)));

Based on this old information https://bugzilla.gnome.org/show_bug.cgi?id=697892#c3 it appears to be a know issue. gstreamer seems to support it https://github.com/GStreamer/gst-plugins-bad/blob/master/gst/mpegtsdemux/gstmpegdefs.h#L50

It looks like the alternate LPCM definition for 0x80 is not defined in ExoPlayer so while there could be issues there wouldn't be a conflict.
@kim-vde
Copy link
Contributor

kim-vde commented Sep 29, 2021

Hi! Can you please provide an example of media file? If you're unable to share test content publicly, please send them to dev.exoplayer@gmail.com using subject "Issue #9472". Please also update this issue to indicate you've done this.

@emveepee
Copy link
Author

Ok email sent.

kim-vde added a commit that referenced this issue Oct 4, 2021
@kim-vde
Map TS stream type 0x80 to H262
8488173 
Issue: #9472
PiperOrigin-RevId: 400715255
@kim-vde
Copy link
Contributor

kim-vde commented Oct 4, 2021

I have added the change directly to ExoPlayer.

Could you please confirm that it fixes the issue? Thanks.

@emveepee
Copy link
Author

emveepee commented Oct 4, 2021

I have added the change directly to ExoPlayer.

Could you please confirm that it fixes the issue? Thanks.

That is is the same (except the define name) as the code I use and it fixes the file in my testing, The user that reported the issue can play live tv on several channels now that didn't work before so this should fix the issue unless the 0x80 PCM audio is ever in the stream.

@kim-vde
Copy link
Contributor

kim-vde commented Oct 4, 2021

I will close the issue then. Please open another issue if you still encounter problems.

@kim-vde kim-vde closed this as completed Oct 4, 2021
@google google locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kim-vde kim-vde

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emveepee @google-oss-bot @kim-vde








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/google/ExoPlayer/issues/9472

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy