Content-Length: 233956 | pFad | https://github.com/h2o/h2o/pull/1498

4D do not invoke network operation when handling internal redirects between defined hosts mapped to different ports by i110 · Pull Request #1498 · h2o/h2o · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not invoke network operation when handling internal redirects between defined hosts mapped to different ports #1498

Merged
merged 1 commit into from
Nov 15, 2017
Merged

do not invoke network operation when handling internal redirects between defined hosts mapped to different ports #1498

merged 1 commit into from
Nov 15, 2017

Conversation

i110
Copy link
Contributor

@i110 i110 commented Nov 10, 2017

When you place listen directive under hosts, like

hosts:
  host1:
    listen:
      host: 0.0.0.0
      port: 8080
    paths:
      /:
        ..
  host2:
    listen:
      host: 0.0.0.0
      port: 8081
    paths:
      /:
        ..

then, internal redirect (reproxy, redirect via location header, errordoc) between host1 and host2 doesn't work and external HTTP request happens.
This PR fixes that issue.

@kazuho kazuho merged commit 6b1f65c into master Nov 15, 2017
@kazuho
Copy link
Member

kazuho commented Nov 15, 2017

Thank you for the fix and especially the tests!

kazuho added a commit that referenced this pull request Dec 7, 2017
@kazuho
Merge pull request #1498 from h2o/i110/i110/fix-internal-redirect
e68489f 
fix internal redirect
@kazuho kazuho changed the title fix internal redirect do not invoke network operation when handling internal redirects between defined hosts mapped to different ports Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i110 @kazuho








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/h2o/h2o/pull/1498

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy