fix offset overflow of SCRIPT_INFO and PATH_INFO #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, it looks like this could actually fix the problems I am experiencing. I will give it a shot, once it is merged. |
|
Thank you for the fixes! |
kazuho
added a commit
that referenced
this pull request
Dec 7, 2017
fix possible offset overflow of SCRIPT_INFO and PATH_INFO
kazuho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several bugs in calculating PATH_INFO and SCRIPT_NAME in mruby handlers.
PATH_INFOgets broken whenconfpath_len_wo_slashis zero and path normalization happens . This is caused by keep mruby's PATH_INFO undecoded #1480SCRIPT_NAMEcan be broken whenreq->pathconf->path.lenis zero and index overflow happens (here). This is a long standing bug, maybeEspecially 1. and 2. may leeds
ArgumentError: string size is too bigerror in mruby layer. This PR fixes these issues.Thank you for finding and reporting the bug @ykzts