Content-Length: 327517 | pFad | https://github.com/lodash/lodash/pull/3103

C4 Enable no-unexpected-multiline by captbaritone · Pull Request #3103 · lodash/lodash · GitHub
Skip to content

Enable no-unexpected-multiline #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2017
Merged

Enable no-unexpected-multiline #3103

merged 1 commit into from
Apr 12, 2017

Conversation

captbaritone
Copy link
Contributor

This rule can help catch errors introduced by automatic semicolon insertion
edge cases. It seems like a sensible thing to have enabled in a code base that
does not use semicolons.

http://eslint.org/docs/rules/no-unexpected-multiline

@captbaritone
Enable no-unexpected-multiline
787eabe 
This rule can help catch errors introduced by automatic semicolon insertion
edge cases. It seems like a sensible thing to have enabled in a code base that
does not use semicolons.

http://eslint.org/docs/rules/no-unexpected-multiline
@jsf-clabot
Copy link

jsf-clabot commented Apr 12, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jdalton
Copy link
Member

jdalton commented Apr 12, 2017

Things pass with the rule enabled?

@captbaritone
Copy link
Contributor Author

@jdalton Yeah

➜  lodash git:(add-no-unexpected-multiline) npm run style

> lodash@4.17.4 style /Users/jelderdge/projects/lodash
> npm run style:main && npm run style:fp && npm run style:perf && npm run style:test


> lodash@4.17.4 style:main /Users/jelderdge/projects/lodash
> eslint lodash.js


> lodash@4.17.4 style:fp /Users/jelderdge/projects/lodash
> eslint fp/*.js lib/**/*.js


> lodash@4.17.4 style:perf /Users/jelderdge/projects/lodash
> eslint perf/*.js perf/**/*.js


> lodash@4.17.4 style:test /Users/jelderdge/projects/lodash
> eslint test/*.js test/**/*.js

@jdalton jdalton merged commit b79b715 into lodash:master Apr 12, 2017
@jdalton
Copy link
Member

jdalton commented Apr 12, 2017

Thanks @captbaritone!

@falsyvalues
Copy link
Contributor

Small note: npm run style is kinda outdated so it's better to run eslint manually.

@jdalton
Copy link
Member

jdalton commented Apr 13, 2017

@falsyvalues would you please modify the npm script to do the right thing.

@falsyvalues
Copy link
Contributor

@jdalton Sure, right away

falsyvalues added a commit to falsyvalues/lodash that referenced this pull request Apr 14, 2017
@falsyvalues
Proper style npm script execution (lodash#3103).
e02db41
This was referenced Apr 19, 2018
Closed
Closed
Closed
Closed
@lock
Copy link

lock bot commented Dec 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@captbaritone @jsf-clabot @jdalton @falsyvalues








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/lodash/lodash/pull/3103

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy