Make emoji autosuggestions immediate, usernames appear sooner #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gargron
commented
Sep 29, 2017
Gargron
commented
- Emoji search does not need to be throttled, since local
- Username autocomplete throttled instead of debounced
- One request is leading, meaning near-immediate first results
- One request is trailing, ensuring latest results
- Debounce would wait until you stopped typing before fetching results, while throttle keeps fetching results even while you type, except in intervals
nightpool
approved these changes
Sep 30, 2017
rutan
pushed a commit
to rutan/mastodon
that referenced
this pull request
Oct 11, 2017
…on#5149) * Do not debounce emoji search * Make autosuggestions appear sooner
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Oct 20, 2017
…on#5149) * Do not debounce emoji search * Make autosuggestions appear sooner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.