Implement hotkeys for web UI #5164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
feature-hotkeys
branch
2 times, most recently
from
95bbf03 to
5a8db84
Compare
nolanlawson
previously requested changes
Oct 2, 2017
There was a problem hiding this comment.
I tested this out in Firefox/Chrome/Safari on Mac and Edge on Windows. Every command is working great in all four browsers except that there is a small bug for the r and m commands where it actually puts the literal letter r or m in the compose box. This bug occurs in Chrome, Safari, and Edge, but not in Firefox.
|
Great feature! |
Gargron
force-pushed
the
feature-hotkeys
branch
from
5a8db84 to
9c075b5
Compare
Hotkeys on status list: - r to reply - m to mention author - f to favourite - b to boost - enter to open status - p to open author's profile - up or k to move up in the list - down or j to move down in the list - 1-9 to focus a status in one of the columns - n to focus the compose textarea - alt+n to start a brand new toot - backspace to navigate back
Gargron
force-pushed
the
feature-hotkeys
branch
from
9c075b5 to
ff7b1b6
Compare
|
@nolanlawson I fixed that, I also made the hotkeys work in notifications column and detailed status view! ✨ |
The key g followed by: - s: start - h: home - n: notifications - l: local timeline - t: federated timeline - f: favourites - u: own profile - p: pinned toots - b: blocked users - m: muted users
ykzts
approved these changes
Oct 5, 2017
|
@Gargron Nice feature! Thank you for your work 👍 🎉
|
rutan
pushed a commit
to rutan/mastodon
that referenced
this pull request
Oct 11, 2017
* Fix mastodon#2102 - Implement hotkeys Hotkeys on status list: - r to reply - m to mention author - f to favourite - b to boost - enter to open status - p to open author's profile - up or k to move up in the list - down or j to move down in the list - 1-9 to focus a status in one of the columns - n to focus the compose textarea - alt+n to start a brand new toot - backspace to navigate back * Add navigational hotkeys The key g followed by: - s: start - h: home - n: notifications - l: local timeline - t: federated timeline - f: favourites - u: own profile - p: pinned toots - b: blocked users - m: muted users * Add hotkey for focusing search, make escape un-focus compose/search * Fix focusing notifications column, fix hotkeys in compose textarea
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Oct 20, 2017
* Fix #2102 - Implement hotkeys Hotkeys on status list: - r to reply - m to mention author - f to favourite - b to boost - enter to open status - p to open author's profile - up or k to move up in the list - down or j to move down in the list - 1-9 to focus a status in one of the columns - n to focus the compose textarea - alt+n to start a brand new toot - backspace to navigate back * Add navigational hotkeys The key g followed by: - s: start - h: home - n: notifications - l: local timeline - t: federated timeline - f: favourites - u: own profile - p: pinned toots - b: blocked users - m: muted users * Add hotkey for focusing search, make escape un-focus compose/search * Fix focusing notifications column, fix hotkeys in compose textarea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://mastodon.social/@Gargron/20188468
Hotkeys:
rto replymto mention authorfto favouritebto boostenterto open statuspto open author's profileuporkto move up in the listdownorjto move down in the list1-9to focus a status in one of the columnsnto focus the compose textareaalt+nto start a brand new tootbackspaceto navigate backsto focus searchescto un-focus compose textarea/search