Track frequently used emojis in web UI #5275
Conversation
Gargron
commented
Oct 8, 2017
•
Gargron
commented
- Click in emoji picker as well as selection of autosuggest increase counter for that emoji
- Settings reducer gets some new events that track whether the settings are "dirty" (unsaved changes)
- Settings save now debounced by 5 seconds (saves API calls)
- Fix [emojos] emoji picker "frequently used" should update with used shortcodes #5203
- Fix Emojos in the new picker don't have tooltips #5144
Gargron
force-pushed
the
feature-frequently-used-emojis
branch
from
ca1e98b to
ac87d88
Compare
|
Seems they grow without bound:
|
|
@nolanlawson They grow to 4 lines, I took over that default from emoi-mart - do you think it should be two lines only? |
|
Also, save is debounced by 5 seconds, so yeah if you immediately refresh they won't save, but I doubt that will happen in practice |
|
I feel like 2 or maybe 3 lines is best but I'm not a heavy emoji user. Maybe good to ask others? |
|
I was trying to test this, but after deleting a custom emoji that was in my recents, the picker does not open anymore.
|
|
I still managed to confirm that tooltips work though 👍 |
|
This is more of a general emoji-mart problem, it does need to be fixed, though separately. |
|
yeah just saying I can't test any further because my picker now always crashes. this is stored server-side? i hope i can find some "phpmyadmin" that works with postgre :S |
|
good, managed to find and delete the JSON object in web_settings using rubymine. Other than that, seems to work okay! Shortcodes from the suggestions bar are added correctly |
* Track frequently used emojis in web UI * Persist emoji usage, but debounce commits to the settings API * Fix mastodon#5144 - Add tooltips to picker * Display only 2 lines of frequently used emojis
* Track frequently used emojis in web UI * Persist emoji usage, but debounce commits to the settings API * Fix mastodon#5144 - Add tooltips to picker * Display only 2 lines of frequently used emojis
